AddFreshSeeds::run() - Code Metrics - Inspection of "Fix withTranslation query scope performance issues..." - dimsav/laravel-translatable - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ac3d15...68a0b7 )

by Dimitrios

created 2018-01-04 19:55 UTC

AddFreshSeeds::run() A

↳ Parent: AddFreshSeeds

Complexity

Conditions	1
Paths	1

Size

Total Lines	55
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	9.7692
c	0
b	0
f	0
cc	1
eloc	36
nc	1
nop	0

How to fix Long Method

<?php

use Dimsav\Translatable\Test\Model\City;
use Dimsav\Translatable\Test\Model\Country;
use Dimsav\Translatable\Test\Model\Vegetable;
use Dimsav\Translatable\Test\Model\CityTranslation;
use Dimsav\Translatable\Test\Model\CountryTranslation;
use Dimsav\Translatable\Test\Model\VegetableTranslation;

class AddFreshSeeds
namespace YourVendor;

class YourClass { }
{
    public function run()
    {
        $countries = [
            ['id' => 1, 'code' => 'gr'],
            ['id' => 2, 'code' => 'fr'],
            ['id' => 3, 'code' => 'en'],
            ['id' => 4, 'code' => 'de'],
        ];

        $this->createCountries($countries);

        $countryTranslations = [
            ['country_id' => 1, 'locale' => 'el', 'name' => 'Ελλάδα'],
            ['country_id' => 1, 'locale' => 'fr', 'name' => 'Grèce'],
            ['country_id' => 1, 'locale' => 'en', 'name' => 'Greece'],
            ['country_id' => 1, 'locale' => 'de', 'name' => 'Griechenland'],
            ['country_id' => 2, 'locale' => 'en', 'name' => 'France'],
        ];

        $this->createCountryTranslations($countryTranslations);

        $cities = [
            ['id' => 1, 'country_id' => 1],
        ];

        $this->createCities($cities);

        $cityTranslations = [
            ['city_id' => 1, 'locale' => 'el', 'name' => 'Αθήνα'],
            ['city_id' => 1, 'locale' => 'fr', 'name' => 'Athènes'],
            ['city_id' => 1, 'locale' => 'en', 'name' => 'Athens'],
            ['city_id' => 1, 'locale' => 'de', 'name' => 'Athen'],
        ];

        $this->createCityTranslations($cityTranslations);

        $vegetables = [
            ['vegetable_identity' => 1],
            ['vegetable_identity' => 2],
        ];

        $this->createVegetables($vegetables);

        $vegetableTranslations = [
            ['vegetable_identity' => 1, 'locale' => 'en',    'name' => 'zucchini'],
            ['vegetable_identity' => 1, 'locale' => 'en-GB', 'name' => 'courgette'],
            ['vegetable_identity' => 1, 'locale' => 'en-US', 'name' => 'zucchini'],
            ['vegetable_identity' => 1, 'locale' => 'de',    'name' => 'Zucchini'],
            ['vegetable_identity' => 1, 'locale' => 'de-CH', 'name' => 'Zucchetti'],
            ['vegetable_identity' => 2, 'locale' => 'en',    'name' => 'aubergine'],
            ['vegetable_identity' => 2, 'locale' => 'en-US', 'name' => 'eggplant'],
        ];

        $this->createVegetableTranslations($vegetableTranslations);
    }

    private function createCountries($countries)
    {
        foreach ($countries as $data) {
            $country = new Country();
            $country->id = $data['id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $country->code = $data['code'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $country->save();
        }
    }

    private function createCountryTranslations($translations)

    {
        foreach ($translations as $data) {
            $translation = new CountryTranslation();
            $translation->country_id = $data['country_id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->locale = $data['locale'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->name = $data['name'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->save();
        }
    }

    private function createCities($cities)
    {
        foreach ($cities as $data) {
            $city = new City();
            $city->id = $data['id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $city->country_id = $data['country_id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $city->save();
        }
    }

    private function createCityTranslations($translations)

    {
        foreach ($translations as $data) {
            $translation = new CityTranslation();
            $translation->city_id = $data['city_id'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->locale = $data['locale'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->name = $data['name'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->save();
        }
    }

    private function createVegetables($vegetables)
    {
        foreach ($vegetables as $vegetable) {
            $vegetable = new Vegetable();
            $vegetable->identity = $vegetable['identity'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $vegetable->save();
        }
    }

    private function createVegetableTranslations($translations)

    {
        foreach ($translations as $data) {
            $translation = new VegetableTranslation();
            $translation->vegetable_identity = $data['vegetable_identity'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->locale = $data['locale'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->name = $data['name'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $translation->save();
        }
    }
}


1		<?php
2
3		use Dimsav\Translatable\Test\Model\City;
4		use Dimsav\Translatable\Test\Model\Country;
5		use Dimsav\Translatable\Test\Model\Vegetable;
6		use Dimsav\Translatable\Test\Model\CityTranslation;
7		use Dimsav\Translatable\Test\Model\CountryTranslation;
8		use Dimsav\Translatable\Test\Model\VegetableTranslation;
9
10		class AddFreshSeeds
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-26 08:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11		{
12		public function run()
13		{
14		$countries = [
15		['id' => 1, 'code' => 'gr'],
16		['id' => 2, 'code' => 'fr'],
17		['id' => 3, 'code' => 'en'],
18		['id' => 4, 'code' => 'de'],
19		];
20
21		$this->createCountries($countries);
22
23		$countryTranslations = [
24		['country_id' => 1, 'locale' => 'el', 'name' => 'Ελλάδα'],
25		['country_id' => 1, 'locale' => 'fr', 'name' => 'Grèce'],
26		['country_id' => 1, 'locale' => 'en', 'name' => 'Greece'],
27		['country_id' => 1, 'locale' => 'de', 'name' => 'Griechenland'],
28		['country_id' => 2, 'locale' => 'en', 'name' => 'France'],
29		];
30
31		$this->createCountryTranslations($countryTranslations);
32
33		$cities = [
34		['id' => 1, 'country_id' => 1],
35		];
36
37		$this->createCities($cities);
38
39		$cityTranslations = [
40		['city_id' => 1, 'locale' => 'el', 'name' => 'Αθήνα'],
41		['city_id' => 1, 'locale' => 'fr', 'name' => 'Athènes'],
42		['city_id' => 1, 'locale' => 'en', 'name' => 'Athens'],
43		['city_id' => 1, 'locale' => 'de', 'name' => 'Athen'],
44		];
45
46		$this->createCityTranslations($cityTranslations);
47
48		$vegetables = [
49		['vegetable_identity' => 1],
50		['vegetable_identity' => 2],
51		];
52
53		$this->createVegetables($vegetables);
54
55		$vegetableTranslations = [
56		['vegetable_identity' => 1, 'locale' => 'en', 'name' => 'zucchini'],
57		['vegetable_identity' => 1, 'locale' => 'en-GB', 'name' => 'courgette'],
58		['vegetable_identity' => 1, 'locale' => 'en-US', 'name' => 'zucchini'],
59		['vegetable_identity' => 1, 'locale' => 'de', 'name' => 'Zucchini'],
60		['vegetable_identity' => 1, 'locale' => 'de-CH', 'name' => 'Zucchetti'],
61		['vegetable_identity' => 2, 'locale' => 'en', 'name' => 'aubergine'],
62		['vegetable_identity' => 2, 'locale' => 'en-US', 'name' => 'eggplant'],
63		];
64
65		$this->createVegetableTranslations($vegetableTranslations);
66		}
67
68		private function createCountries($countries)
69		{
70		foreach ($countries as $data) {
71		$country = new Country();
72		$country->id = $data['id'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Dimsav\Translatable\Test\Model\Country>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
73		$country->code = $data['code'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `code` does not exist on `object<Dimsav\Translatable\Test\Model\Country>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
74		$country->save();
75		}
76		}
77
78	View Code Duplication	private function createCountryTranslations($translations)
		0 ignored issues – show Duplication introduced 2017-08-04 15:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		{
80		foreach ($translations as $data) {
81		$translation = new CountryTranslation();
82		$translation->country_id = $data['country_id'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `country_id` does not exist on `object<Dimsav\Translatab...del\CountryTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
83		$translation->locale = $data['locale'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `locale` does not exist on `object<Dimsav\Translatab...del\CountryTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
84		$translation->name = $data['name'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Dimsav\Translatab...del\CountryTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
85		$translation->save();
86		}
87		}
88
89		private function createCities($cities)
90		{
91		foreach ($cities as $data) {
92		$city = new City();
93		$city->id = $data['id'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Dimsav\Translatable\Test\Model\City>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
94		$city->country_id = $data['country_id'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `country_id` does not exist on `object<Dimsav\Translatable\Test\Model\City>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
95		$city->save();
96		}
97		}
98
99	View Code Duplication	private function createCityTranslations($translations)
		0 ignored issues – show Duplication introduced 2017-08-04 15:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100		{
101		foreach ($translations as $data) {
102		$translation = new CityTranslation();
103		$translation->city_id = $data['city_id'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `city_id` does not exist on `object<Dimsav\Translatab...\Model\CityTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
104		$translation->locale = $data['locale'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `locale` does not exist on `object<Dimsav\Translatab...\Model\CityTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
105		$translation->name = $data['name'];
		0 ignored issues – show Documentation introduced 2016-08-10 12:17 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Dimsav\Translatab...\Model\CityTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
106		$translation->save();
107		}
108		}
109
110		private function createVegetables($vegetables)
111		{
112		foreach ($vegetables as $vegetable) {
113		$vegetable = new Vegetable();
114		$vegetable->identity = $vegetable['identity'];
		0 ignored issues – show Documentation introduced 2017-11-17 11:44 UTC by Report Bug Copy Issue Report The property `identity` does not exist on `object<Dimsav\Translatable\Test\Model\Vegetable>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
115		$vegetable->save();
116		}
117		}
118
119	View Code Duplication	private function createVegetableTranslations($translations)
		0 ignored issues – show Duplication introduced 2017-11-17 11:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		{
121		foreach ($translations as $data) {
122		$translation = new VegetableTranslation();
123		$translation->vegetable_identity = $data['vegetable_identity'];
		0 ignored issues – show Documentation introduced 2017-11-17 11:44 UTC by Report Bug Copy Issue Report The property `vegetable_identity` does not exist on `object<Dimsav\Translatab...l\VegetableTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
124		$translation->locale = $data['locale'];
		0 ignored issues – show Documentation introduced 2017-11-17 11:44 UTC by Report Bug Copy Issue Report The property `locale` does not exist on `object<Dimsav\Translatab...l\VegetableTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
125		$translation->name = $data['name'];
		0 ignored issues – show Documentation introduced 2017-11-17 11:44 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Dimsav\Translatab...l\VegetableTranslation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
126		$translation->save();
127		}
128		}
129		}
130

dimsav / laravel-translatable

Push — master ( ac3d15...68a0b7 )

AddFreshSeeds::run() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like