Application::__o() - Code Metrics - Inspection of "Merge branch 'master' of github.com:dimaxz/framewo..." - dimaxz/frameworkless - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4fb45...fd4491 )

by dima

created 2016-10-13 21:33 UTC

Application::__o() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	1
nc	1
nop	0

<?php

namespace Frameworkless\Console;

use Symfony\Component\Console\Application as CoreApp;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Finder\Finder;

class Application extends CoreApp
{
    /**
     * Gets the name of the command based on input.
     *
     * @param InputInterface $input The input interface
     *
     * @return string The command name
     */
    protected function getCommandName(InputInterface $input)
    {
        // This should return the name of your command.
        return 'help';
    }
//	

//	protected function my_command(){
//		exit('f');
//	}

	/**
     * Gets the default commands that should always be available.
     *
     * @return array An array of default Command instances
     */
    protected function getDefaultCommands()
    {
        // Keep the core default commands to have the HelpCommand
        // which is used when using the --help option
        $defaultCommands = parent::getDefaultCommands();

        $defaultCommands[] = new \Symfony\Component\Console\Command\HelpCommand();

		$defaultCommands[] = new \Frameworkless\Console\Commands\TestCommand();

        return $defaultCommands;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Overridden so that the application doesn't expect the command
     * name to be the first argument.
     */
    public function getDefinition()
    {
        $inputDefinition = parent::getDefinition();
        // clear out the normal first argument, which is the command name
        $inputDefinition->setArguments();

        return $inputDefinition;
    }
	
	
	
	
	
	
	function __o(){


	}
}

1			<?php
2
3			namespace Frameworkless\Console;
4
5			use Symfony\Component\Console\Application as CoreApp;
6			use Symfony\Component\Console\Input\InputInterface;
7			use Symfony\Component\Console\Output\OutputInterface;
8			use Symfony\Component\Console\Input\InputArgument;
9			use Symfony\Component\Console\Input\InputOption;
10			use Symfony\Component\Finder\Finder;
11
12			class Application extends CoreApp
13			{
14			/**
15			* Gets the name of the command based on input.
16			*
17			* @param InputInterface $input The input interface
18			*
19			* @return string The command name
20			*/
21			protected function getCommandName(InputInterface $input)
22			{
23			// This should return the name of your command.
24			return 'help';
25			}
26			//
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-12 13:03 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27			// protected function my_command(){
28			// exit('f');
29			// }
30
31			/**
32			* Gets the default commands that should always be available.
33			*
34			* @return array An array of default Command instances
35			*/
36			protected function getDefaultCommands()
37			{
38			// Keep the core default commands to have the HelpCommand
39			// which is used when using the --help option
40			$defaultCommands = parent::getDefaultCommands();
41
42			$defaultCommands[] = new \Symfony\Component\Console\Command\HelpCommand();
43
44			$defaultCommands[] = new \Frameworkless\Console\Commands\TestCommand();
45
46			return $defaultCommands;
			0 ignored issues – show Best Practice introduced 2016-10-13 21:36 UTC by Report Bug Copy Issue Report The expression `return $defaultCommands;` seems to be an `array`, but some of its elements' types (`Frameworkless\Console\Commands\TestCommand`) are incompatible with the return type of the parent method `Symfony\Component\Consol...ion::getDefaultCommands` of type `array<Symfony\Component\...le\Command\ListCommand>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
47			}
48
49			/**
50			* Overridden so that the application doesn't expect the command
51			* name to be the first argument.
52			*/
53			public function getDefinition()
54			{
55			$inputDefinition = parent::getDefinition();
56			// clear out the normal first argument, which is the command name
57			$inputDefinition->setArguments();
58
59			return $inputDefinition;
60			}
61
62
63
64
65
66
67			function __o(){
			0 ignored issues – show Best Practice introduced 2016-10-12 13:03 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
68
69			}
70			}

dimaxz / frameworkless

Push — master ( b4fb45...fd4491 )

Application::__o() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like