Frameworkless\ValidatorTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	preSave()	0	7	2

<?php
namespace Frameworkless;

use Symfony\Component\Validator\Validator\RecursiveValidator;
use Symfony\Component\Validator\Mapping\Factory\LazyLoadingMetadataFactory;
use Symfony\Component\Validator\ConstraintValidatorFactory;
use Symfony\Component\Translation\IdentityTranslator;
use Symfony\Component\Validator\Mapping\Loader\StaticMethodLoader;
use Symfony\Component\Validator\Context\ExecutionContextFactory;
use Frameworkless\Exceptions\ValidationException;
/**
 * Description of ValidatorTrait
 *
 * @author Dmitriy
 */
trait ValidatorTrait
{
	/**
	 * Symfony\Component\Validator\Validator\RecursiveValidator
	 * @var type 
	 */
	protected $validator;
			
    function __construct()

It is generally recommended to explicitly declare the visibility for methods.

	{
		$this->validator = new RecursiveValidator(

It seems like new \Symfony\Component\Validator\Validator\RecursiveValidator(new \Symfony\Component\Validator\Context\ExecutionContextFactory(new \Symfony\Component\Translation\IdentityTranslator()), new \Symfony\Component\Validator\Mapping\Factory\LazyLoadingMetadataFactory(new \Symfony\Component\Validator\Mapping\Loader\StaticMethodLoader()), new \Symfony\Component\Validator\ConstraintValidatorFactory()) of type object<Symfony\Component\Validator\Validator\RecursiveValidator> is incompatible with the declared type object<Frameworkless\type> of property $validator.

            new ExecutionContextFactory(new IdentityTranslator()),
            new LazyLoadingMetadataFactory(new StaticMethodLoader()),
            new ConstraintValidatorFactory()
        );
	}
	
	public function preSave(\Propel\Runtime\Connection\ConnectionInterface $con = null)

The parameter $con is not used and could be removed.

	{
        if (!$result = $this->validate($this->validator)) {

It seems like validate() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw new ValidationException($this->getValidationFailures(),"Validation error");

It seems like getValidationFailures() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }     		
		return $result;
	}	
}