SimpleORM\TraitDataMapperEvent

Complexity

Total Complexity

18

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	onPrepareData()	0	7	5
A	onBeforeDelete()	0	14	4
C	onAfterSave()	0	39	8
A	onBeforeSave()	0	17	1

<?php
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

namespace SimpleORM;

/**
 * Description of TraitDataMapperEvent
 *
 * @author d.lanec
 */
trait TraitDataMapperEvent {

	/**
	 * Перед сохранением извелкаем объект и дополняем массив для записи, недостающими полями
	 * @param \Autoprice\Domain\Price\EntityInterface $Entity
	 * @param type $data
	 */
	protected function onPrepareData(\SimpleORM\EntityInterface $Entity, &$data) {

The parameter $Entity is not used and could be removed.

		foreach ($this->mapping_fields as $field => $cfg) {

The property mapping_fields does not exist. Did you maybe forget to declare it?

			if (isset($cfg['null']) && $cfg['null'] === false && empty($data[$cfg['field']])) {
				$data[$cfg['field']] = $cfg['default'];
			}
		}
	}

	/**
	 * На успешное удаление
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onBeforeDelete(EntityInterface $Entity) {
		foreach ($this->relations as $alias => $cfg) {

The property relations does not exist. Did you maybe forget to declare it?

			$mapper = $cfg['mapper'];
			//если связь один к одному то удаляем сущность
			if ($cgg['reltype'] == 'has_one') {

The variable $cgg does not exist. Did you forget to declare it?

				$Entity = $Entity->{'get' . $alias}();
				if (!$mapper->delete($Entity)) {
					throw new \Autoprice\Exceptions\EntityNotDeleteException('Unable to delete Entity!');
				}
			}
		}

		return true;
	}

	/**
	 * Событие перед сохранением
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onAfterSave(EntityInterface $Entity) {

		$this->getAdapter()->startTransaction();

It seems like getAdapter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		$rel_list = $this->createListRelation();

It seems like createListRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		foreach ($rel_list as $obj_path => $mapper) {

			$call_obj = '$Entity'.$obj_path.';';

			$set_path = str_replace(['#', '();'], ['->set', '($o);'], $call_obj);
		
			$ar_path = explode('()',$obj_path);
			
			$o = $Entity;
		
			foreach ($ar_path as $_m){
				
				$_mc = str_replace('#','get',mb_ucfirst($_m));

				//Set logic
				if(empty($_m)){
				
					$_mc = ltrim( $ar_path[(count($ar_path)-2)] , '#');
					
					if (is_object($$_mc) && is_a($$_mc,'SimpleORM\EntityInterface') && $this->DI->get($mapper)->saveWithoutEvents($o)) {

The property DI does not exist. Did you maybe forget to declare it?

						$o = $$_mc;
						eval($set_path);

It is generally not recommended to use eval unless absolutely required.

					}
				}
				elseif(is_object($o) ){
					$$_mc = $o->{$_mc}();
					$o = $$_mc;
				}
				
			}
			
		}
	}

	/**
	 * После успешного сохранения
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onBeforeSave(EntityInterface $Entity) {

The parameter $Entity is not used and could be removed.

		$this->getAdapter()->endTransaction();

It seems like getAdapter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

//		foreach ($this->relations as $alias => $mapper) {

57% of this comment could be valid code. Did you maybe forget this after debugging?

//		
//			$SaveEntity = $Entity->{'get'.$alias}();
//			
//			if(!$mapper->save($SaveEntity)){
//				throw new \Autoprice\Exceptions\EntityNotSaveException('Unable to save Entity!');
//			}
//			
//			unset($SaveEntity);
//		}
//		
//		return true;
	}

}