TraitDataMapperEvent - Code Metrics - Inspection of "улучшение маппера" - dimaxz/SimpleORM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a52660...7c30c4 )

by dima

created 2016-03-14 21:37 UTC

TraitDataMapperEvent A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	0

Test Coverage

Coverage

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	19
c	4
b	0
f	0
lcom	3
cbo	0
dl	0
loc	101
ccs	0
cts	44
cp	0
rs	10

4 Methods

Rating	Name	Size	Complexity
B	onPrepareData()	7	5
A	onBeforeDelete()	14	4
A	onBeforeSave()	17	1
D	onAfterSave()	39	9

<?php
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

namespace SimpleORM;

/**
 * Description of TraitDataMapperEvent
 *
 * @author d.lanec
 */
trait TraitDataMapperEvent {

	/**
	 * Перед сохранением извелкаем объект и дополняем массив для записи, недостающими полями
	 * @param \Autoprice\Domain\Price\EntityInterface $Entity
	 * @param type $data
	 */
	protected function onPrepareData(\SimpleORM\EntityInterface $Entity, &$data) {

		foreach ($this->mapping_fields as $field => $cfg) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
			if (isset($cfg['null']) && $cfg['null'] === false && empty($data[$cfg['field']])) {
				$data[$cfg['field']] = $cfg['default'];
			}
		}
	}

	/**
	 * На успешное удаление
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onBeforeDelete(EntityInterface $Entity) {
		foreach ($this->relations as $alias => $cfg) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$mapper = $cfg['mapper'];
			//если связь один к одному то удаляем сущность
			if ($cfg['reltype'] == 'has_one') {
				$Entity = $Entity->{'get' . $alias}();
				if (!$mapper->delete($Entity)) {
					throw new \Autoprice\Exceptions\EntityNotDeleteException('Unable to delete Entity!');
				}
			}
		}

		return true;
	}

	/**
	 * Событие перед сохранением
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onAfterSave(EntityInterface $Entity) {

		$this->getAdapter()->startTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

		$rel_list = $this->createListRelation();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

		foreach ($rel_list as $obj_path => $mapper) {

			$call_obj = '$Entity'.$obj_path.';';

			$set_path = str_replace(['#', '();'], ['->set', '($o);'], $call_obj);
		
			$ar_path = explode('()',$obj_path);
			
			$o = $Entity;
		
			foreach ($ar_path as $_m){
				
				$_mc = str_replace('#','get',ucfirst($_m));

				//Set logic
				if(empty($_m)){
			
					$_mc = ltrim( $ar_path[(count($ar_path)-2)] , '#');
					
					if (isset($$_mc) && is_object($$_mc) && is_a($$_mc,'SimpleORM\EntityInterface') && $this->DI->get($mapper)->saveWithoutEvents($o)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
						$o = $$_mc;
						eval($set_path);

					}
				}
				elseif(is_object($o) ){
					$$_mc = $o->{$_mc}();
					$o = $$_mc;
				}
				
			}
			
		}
	}

	/**
	 * После успешного сохранения
	 * @param \SimpleORM\EntityInterface $Entity
	 */
	protected function onBeforeSave(EntityInterface $Entity) {


		$this->getAdapter()->endTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

//		foreach ($this->relations as $alias => $mapper) {

//		
//			$SaveEntity = $Entity->{'get'.$alias}();
//			
//			if(!$mapper->save($SaveEntity)){
//				throw new \Autoprice\Exceptions\EntityNotSaveException('Unable to save Entity!');
//			}
//			
//			unset($SaveEntity);
//		}
//		
//		return true;
	}

}


1			<?php
2			/*
3			* To change this license header, choose License Headers in Project Properties.
4			* To change this template file, choose Tools \| Templates
5			* and open the template in the editor.
6			*/
7
8			namespace SimpleORM;
9
10			/**
11			* Description of TraitDataMapperEvent
12			*
13			* @author d.lanec
14			*/
15			trait TraitDataMapperEvent {
16
17			/**
18			* Перед сохранением извелкаем объект и дополняем массив для записи, недостающими полями
19			* @param \Autoprice\Domain\Price\EntityInterface $Entity
20			* @param type $data
21			*/
22			protected function onPrepareData(\SimpleORM\EntityInterface $Entity, &$data) {
			0 ignored issues – show Unused Code introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report The parameter `$Entity` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23			foreach ($this->mapping_fields as $field => $cfg) {
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report The property `mapping_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			if (isset($cfg['null']) && $cfg['null'] === false && empty($data[$cfg['field']])) {
25			$data[$cfg['field']] = $cfg['default'];
26			}
27			}
28			}
29
30			/**
31			* На успешное удаление
32			* @param \SimpleORM\EntityInterface $Entity
33			*/
34			protected function onBeforeDelete(EntityInterface $Entity) {
35			foreach ($this->relations as $alias => $cfg) {
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report The property `relations` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			$mapper = $cfg['mapper'];
37			//если связь один к одному то удаляем сущность
38			if ($cfg['reltype'] == 'has_one') {
39			$Entity = $Entity->{'get' . $alias}();
40			if (!$mapper->delete($Entity)) {
41			throw new \Autoprice\Exceptions\EntityNotDeleteException('Unable to delete Entity!');
42			}
43			}
44			}
45
46			return true;
47			}
48
49			/**
50			* Событие перед сохранением
51			* @param \SimpleORM\EntityInterface $Entity
52			*/
53			protected function onAfterSave(EntityInterface $Entity) {
54
55			$this->getAdapter()->startTransaction();
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report It seems like `getAdapter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56
57			$rel_list = $this->createListRelation();
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report It seems like `createListRelation()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
58
59			foreach ($rel_list as $obj_path => $mapper) {
60
61			$call_obj = '$Entity'.$obj_path.';';
62
63			$set_path = str_replace(['#', '();'], ['->set', '($o);'], $call_obj);
64
65			$ar_path = explode('()',$obj_path);
66
67			$o = $Entity;
68
69			foreach ($ar_path as $_m){
70
71			$_mc = str_replace('#','get',ucfirst($_m));
72
73			//Set logic
74			if(empty($_m)){
75
76			$_mc = ltrim( $ar_path[(count($ar_path)-2)] , '#');
77
78			if (isset($$_mc) && is_object($$_mc) && is_a($$_mc,'SimpleORM\EntityInterface') && $this->DI->get($mapper)->saveWithoutEvents($o)) {
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report The property `DI` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
79			$o = $$_mc;
80			eval($set_path);
			0 ignored issues – show Coding Style introduced 2015-12-16 14:50 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
81			}
82			}
83			elseif(is_object($o) ){
84			$$_mc = $o->{$_mc}();
85			$o = $$_mc;
86			}
87
88			}
89
90			}
91			}
92
93			/**
94			* После успешного сохранения
95			* @param \SimpleORM\EntityInterface $Entity
96			*/
97			protected function onBeforeSave(EntityInterface $Entity) {
			0 ignored issues – show Unused Code introduced 2015-12-16 14:50 UTC by Report Bug Copy Issue Report The parameter `$Entity` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
98
99			$this->getAdapter()->endTransaction();
			0 ignored issues – show Bug introduced 2015-12-22 06:25 UTC by Report Bug Copy Issue Report It seems like `getAdapter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
100
101			// foreach ($this->relations as $alias => $mapper) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-04 20:40 UTC by Report Bug Copy Issue Report `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
102			//
103			// $SaveEntity = $Entity->{'get'.$alias}();
104			//
105			// if(!$mapper->save($SaveEntity)){
106			// throw new \Autoprice\Exceptions\EntityNotSaveException('Unable to save Entity!');
107			// }
108			//
109			// unset($SaveEntity);
110			// }
111			//
112			// return true;
113			}
114
115			}
116

dimaxz / SimpleORM

Push — master ( a52660...7c30c4 )

TraitDataMapperEvent A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like