dimaslanjaka / universal-framework

src/Proxy/db.php

<?php

namespace Proxy;

$GLOBALS['proxy_loaded'] = null;

class db
{
  /**
   * PDO.
   *
   * @var \DB\pdo
   */
  private $pdo = null;

  public function __construct(\DB\pdo $pdo)
  {
    global $GLOBALS;
    if (!$GLOBALS['proxy_loaded']) {
      $this->load_proxies_db();
    }
    $this->pdo = $pdo;
  }

  public function random_proxy(int $n = 1)

The parameter $n is not used and could be removed.

  {
  }

  public function inactive_proxies()
  {
    return $this->pdo->query("SELECT * FROM `proxies` WHERE `status` = 'inactive'")->row_array();
  }

  public function load_proxies_db()
  {
    $proxies = $this->pdo
      ->select('proxies')
      ->where(['country' => null, 'status' => 'active'])
      ->row_array();
    \Filemanager\file::file(__DIR__ . '/proxies/db.json', $proxies, true);

It seems like $proxies can also be of type array; however, parameter $create of Filemanager\file::file() does only seem to accept boolean, maybe add an additional type check?

    return $proxies;
  }

  public function load_proxies()
  {
    return json_decode(\Filemanager\file::get(__DIR__ . '/proxies/db.json'));

It seems like Filemanager\file::get(__DIR__ . '/proxies/db.json') can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

  }
}