dimaslanjaka / universal-framework

src/MVC/captcha.php

<?php

namespace MVC;

class captcha extends router
{
  public $key = null;
  private $request_headers = [];
  private $cors = null;

  public function __construct()
  {
    $_SESSION['md5-useragent'] = md5($_SERVER['HTTP_USER_AGENT']);
    $this->key = 'captcha' . md5(\MVC\helper::get_client_ip() . $_SERVER['HTTP_USER_AGENT']);
    $this->cors = \MVC\helper::cors();

    if (!function_exists('getallheaders')) {
      foreach ($_SERVER as $name => $value) {
        /* RFC2616 (HTTP/1.1) defines header fields as case-insensitive entities. */
        if ('http_' == strtolower(substr($name, 0, 5))) {
          $headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
        }
      }
      $this->request_headers = $headers;

The variable $headers does not seem to be defined for all execution paths leading up to this point.

    } else {
      $this->request_headers = getallheaders();
    }
  }

  /**
   * Receiver (Create captcha).
   *
   * @param string $header_name javascript function name in header format
   *
   * @return void
   */
  public function receiver(string $header_name = 'hname')
  {
    return $this->receiver2($header_name);

Are you sure the usage of $this->receiver2($header_name) targeting MVC\captcha::receiver2() seems to always return null.

  }

  public function receiver2(string $header_name = null)
  {
    if (!$this->cors) {
      return;
    }
    if (!$header_name) {
      $header_name = str_rot13(\MVC\helper::getRequestIP());
    }
    $allow = isset($this->request_headers[$header_name]);

    if ($allow) {
      $header = $this->request_headers[$header_name];
      $header_match = str_rot13($header) == $_SESSION['md5-useragent'];
      if ($header_match) {
        if (isset($_REQUEST['callback'])) {
          header('Content-Type: application/javascript');
          $create = $this->create();

Are you sure the assignment to $create is correct as $this->create() targeting MVC\captcha::create() seems to always return null.

          $gen = json_encode(['captcha' => str_rot13($create)]);

$create of type void is incompatible with the type string expected by parameter $string of str_rot13().

          echo "{$_REQUEST['callback']}($gen)";
          exit;

Using exit here is not recommended.

        }
      }
    }
  }

  private function delete_headers(int $http_code = 200)

The method delete_headers() is not used, and could be removed.

  {
    if (ob_get_level()) {
      ob_end_clean();
      ob_start();
    }
    http_response_code($http_code);
  }

  /**
   * Create captcha ids.
   *
   * @return void
   */
  public function create()
  {
    $random_alpha = md5(rand());
    $captcha_code = (string) substr($random_alpha, 0, 6);
    \Cookie\helper::mins($this->key, $captcha_code, 1, '/');

    return $captcha_code;

The expression return $captcha_code returns the type string which is incompatible with the documented return type void.

  }

  /**
   * Validate coupon codes.
   *
   * @param string $captcha
   *
   * @return void
   */
  public function validate(string $captcha)
  {
    if (\Cookie\helper::has($this->key)) {
      return \Cookie\helper::get($this->key) == $captcha;

The expression return Cookie\helper::get($this->key) == $captcha returns the type boolean which is incompatible with the documented return type void.

    } else {
      if (\MVC\helper::cors()) {
        exit(\JSON\json::json(['message' => "Session {$this->key} not exists", 'error' => true]));

Using exit here is not recommended.

Are you sure the usage of JSON\json::json(array('message' => 'Session '.$this->key.' not exists', 'error' => true)) targeting JSON\json::json() seems to always return null.

      } else {
        throw new Exception("Session {$this->key} not exists", 1);
      }
    }
  }

  public function jpeg(string $captcha_code)
  {
    $target_layer = imagecreatetruecolor(70, 30);
    $captcha_background = imagecolorallocate($target_layer, 255, 160, 119);
    imagefill($target_layer, 0, 0, $captcha_background);
    $captcha_text_color = imagecolorallocate($target_layer, 0, 0, 0);
    imagestring($target_layer, 5, 5, 5, str_rot13($captcha_code), $captcha_text_color);
    header('Content-type: image/jpeg');
    imagejpeg($target_layer);
  }
}