dimaslanjaka / universal-framework

src/HTML/js.php

<?php

namespace HTML;

class js
{
  public static function js_str($s)
  {
    return '"' . addcslashes($s, "\0..\37\"\\") . '"';
  }

  public static function js_array(array $array)
  {
    $temp = array_map(function ($index) {
      return self::js_str($index);
    }, $array);

    return '[' . implode(',', $temp) . ']';
  }

  /**
   * Create javascript variable.
   *
   * @param string              $variable variable name
   * @param string|array|object $content  array object will turn into JSON javascript object
   *
   * @return string var name = content;
   */
  public static function var(string $variable, $content)
  {
    if (\ArrayHelper\helper::is_iterable($content)) {

It seems like $content can also be of type string; however, parameter $objarr of ArrayHelper\helper::is_iterable() does only seem to accept array|object, maybe add an additional type check?

      $content = \JSON\json::json($content, false, false);
    }
    if (false !== strpos($content, ';')) {
      $content = rtrim($content, ';');
    }

    return 'var ' . $variable . ' = `' . $content . '`;';

Are you sure $content of type array|object|string can be used in concatenation?

  }
}