dimaslanjaka / universal-framework

libs/js/websocket.js

/**
 * Simple Websocket javascript
 * @todo Live Data
 * @description Don't miss data that changes even for a second
 * @author Dimas Lanjaka <dimaslanjaka[at]gmail.com
 * @see https://www.webmanajemen.com/p/simple-websocket.html Simple Web Socket
 */
var socket;

function socket_start(host) {
  if (!host) {
    console.error('Host websocket empty');
    return;
  }
  if (!socket_check()) {
    console.log('WebSocket Started');

console.log looks like debug code. Are you sure you do not want to remove it?

    socket = socket_server(host);
  }
  try {
    
    socket.onopen = function(msg) {

The variable socket does not seem to be initialized in case !socket_check() on line 15 is false. Are you sure this can never be the case?

      console.log('socket initialized');

console.log looks like debug code. Are you sure you do not want to remove it?

    };
    socket.onmessage = function(msg) {
      var data = JSON.parse(msg.data);
      //do with data response
      console.log(data);

console.log looks like debug code. Are you sure you do not want to remove it?

    };
    
    socket.onclose = function(msg) {
      console.log({

console.log looks like debug code. Are you sure you do not want to remove it?

        closed: socket

The variable socket does not seem to be initialized in case !socket_check() on line 15 is false. Are you sure this can never be the case?

      });
    };
  } catch (ex) {
    console.log(ex);
  }
}

function socket_server(host) {
  if (!host) {
    console.error('Host websocket empty');
    return;

Are you sure this return statement is not missing an argument? If this is intended, consider adding an explicit undefined like return undefined;.

  }
  console.log('Socket Initialized');

console.log looks like debug code. Are you sure you do not want to remove it?

  if (!window.EventSource) {
    var socket = new EventSource(host);
  } else {
    
    var socket = new WebSocket(host);

The variable socket already seems to be declared on line 47. Consider using another variable name or omitting the var keyword.

  }
  return socket;
}

function socket_stop() {
  if (socket != null) {
    console.log("WebSocket Stopped");

console.log looks like debug code. Are you sure you do not want to remove it?

    socket.close();
    socket = null;
  }
}

function socket_check() {
  return socket;
}