backup_tables()

Complexity

Conditions	22
Paths	4188

Size

Total Lines	137
Code Lines	88

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function backup_tables($DBH, $tables)
{
  $DBH->setAttribute(PDO::ATTR_ORACLE_NULLS, PDO::NULL_NATURAL);

  //Script Variables
  $compression = false;
  $BACKUP_PATH = '';
  $nowtimename = time();

  //create/open files
  if ($compression) {

The condition $compression is always false.

    $zp = gzopen($BACKUP_PATH . $nowtimename . '.sql.gz', 'a9');
  } else {
    $handle = fopen($BACKUP_PATH . $nowtimename . '.sql', 'a+');
  }

  //array of all database field types which just take numbers
  $numtypes = ['tinyint', 'smallint', 'mediumint', 'int', 'bigint', 'float', 'double', 'decimal', 'real'];

  //get all of the tables
  if (empty($tables)) {
    $pstm1 = $DBH->query('SHOW TABLES');
    while ($row = $pstm1->fetch(PDO::FETCH_NUM)) {
      $tables[] = $row[0];
    }
  } else {
    $tables = is_array($tables) ? $tables : explode(',', $tables);
  }

  //cycle through the table(s)

  foreach ($tables as $table) {
    $result = $DBH->query("SELECT * FROM $table");
    $num_fields = $result->columnCount();
    $num_rows = $result->rowCount();

    $return = '';
    //uncomment below if you want 'DROP TABLE IF EXISTS' displayed
    //$return.= 'DROP TABLE IF EXISTS `'.$table.'`;';

    //table structure
    $pstm2 = $DBH->query("SHOW CREATE TABLE $table");
    $row2 = $pstm2->fetch(PDO::FETCH_NUM);
    $ifnotexists = str_replace('CREATE TABLE', 'CREATE TABLE IF NOT EXISTS', $row2[1]);
    $return .= "\n\n" . $ifnotexists . ";\n\n";

    if ($compression) {
      gzwrite($zp, $return);

The variable $zp does not seem to be defined for all execution paths leading up to this point.

    } else {
      fwrite($handle, $return);

The variable $handle does not seem to be defined for all execution paths leading up to this point.

It seems like $handle can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

    }
    $return = '';

    //insert values
    if ($num_rows) {
      $return = 'INSERT INTO `' . "$table" . '` (';
      $pstm3 = $DBH->query("SHOW COLUMNS FROM $table");
      $count = 0;
      $type = [];

      while ($rows = $pstm3->fetch(PDO::FETCH_NUM)) {
        if (stripos($rows[1], '(')) {
          $type[$table][] = stristr($rows[1], '(', true);
        } else {
          $type[$table][] = $rows[1];
        }

        $return .= '`' . $rows[0] . '`';
        ++$count;
        if ($count < ($pstm3->rowCount())) {
          $return .= ', ';
        }
      }

      $return .= ')' . ' VALUES';

      if ($compression) {
        gzwrite($zp, $return);
      } else {
        fwrite($handle, $return);
      }
      $return = '';
    }
    $count = 0;
    while ($row = $result->fetch(PDO::FETCH_NUM)) {
      $return = "\n\t(";

      for ($j = 0; $j < $num_fields; ++$j) {
        //$row[$j] = preg_replace("\n","\\n",$row[$j]);

        if (isset($row[$j])) {
          //if number, take away "". else leave as string
          if ((in_array($type[$table][$j], $numtypes)) && (!empty($row[$j]))) {

The variable $type does not seem to be defined for all execution paths leading up to this point.

            $return .= $row[$j];
          } else {
            $return .= $DBH->quote($row[$j]);
          }
        } else {
          $return .= 'NULL';
        }
        if ($j < ($num_fields - 1)) {
          $return .= ',';
        }
      }
      ++$count;
      if ($count < ($result->rowCount())) {
        $return .= '),';
      } else {
        $return .= ');';
      }
      if ($compression) {
        gzwrite($zp, $return);
      } else {
        fwrite($handle, $return);
      }
      $return = '';
    }
    $return = "\n\n-- ------------------------------------------------ \n\n";
    if ($compression) {
      gzwrite($zp, $return);
    } else {
      fwrite($handle, $return);
    }
    $return = '';

The assignment to $return is dead and can be removed.

  }

  $error1 = $pstm2->errorInfo();

The variable $pstm2 seems to be defined by a foreach iteration on line 42. Are you sure the iterator is never empty, otherwise this variable is not defined?

  $error2 = $pstm3->errorInfo();

The variable $pstm3 does not seem to be defined for all execution paths leading up to this point.

  $error3 = $result->errorInfo();

The variable $result seems to be defined by a foreach iteration on line 42. Are you sure the iterator is never empty, otherwise this variable is not defined?

  echo $error1[2];
  echo $error2[2];
  echo $error3[2];

  if ($compression) {
    gzclose($zp);
  } else {
    fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

  }