dimaslanjaka /
universal-framework
| Conditions | 10 |
| Paths | 4 |
| Total Lines | 13 |
| Code Lines | 7 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 4 | function humanFileSize($size, $unit = '') |
||
| 5 | { |
||
| 6 | if ((!$unit && $size >= 1 << 30) || 'GB' == $unit) { |
||
| 7 | return number_format($size / (1 << 30), 2) . ' GB'; |
||
| 8 | } |
||
| 9 | if ((!$unit && $size >= 1 << 20) || 'MB' == $unit) { |
||
| 10 | return number_format($size / (1 << 20), 2) . ' MB'; |
||
| 11 | } |
||
| 12 | if ((!$unit && $size >= 1 << 10) || 'KB' == $unit) { |
||
| 13 | return number_format($size / (1 << 10), 2) . ' KB'; |
||
| 14 | } |
||
| 15 | |||
| 16 | return number_format($size) . ' bytes'; |
||
| 17 | } |
||
| 18 |
