schema::modify_enumset_values() - Code Metrics - dimaslanjaka/universal-framework - Measure and Improve Code Quality continuously with Scrutinizer

schema::modify_enumset_values() A
last analyzed 2021-05-12 13:02 UTC

↳ Parent: schema

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	4
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

namespace DB;

use PDO as GlobalPDO;

class schema
{
  /**
   * Get ENUM or SET values.
   *
   * @return array
   */
  public static function get_enumset_values(\DB\pdo $pdo, string $table, string $field)
  {
    $type = $pdo->query("SHOW COLUMNS FROM {$table} WHERE Field = '{$field}'")->row_array()['Type'];
    $result = [];
    if (preg_match("/^enum\(\'(.*)\'\)$/", $type, $matches)) {
      $enum = explode("','", $matches[1]);

      $result = $enum;
    } elseif (preg_match("/^set\(\'(.*)\'\)$/", $type, $matches)) {
      $set = explode("','", $matches[1]);

      $result = $set;
    }

    return array_values(array_unique($result));
  }

  /**
   * Modify ENUM or SET values.
   * @see https://stackoverflow.com/questions/1501958/how-do-i-add-more-members-to-my-enum-type-column-in-mysql
   * @return array
   */
  public static function modify_enumset_values(\DB\pdo $pdo, string $table, string $field, array $newData)
  {
    for ($i = 0; $i < count($newData); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
      $newData[$i] = "'$newData[$i]'";
    }
    $data = implode(', ', array_values(array_unique($newData)));
    $sql = "ALTER TABLE `$table` MODIFY COLUMN `$field` SET($data) NOT NULL";
    return $pdo->query($sql)->exec();
  }

  /**
   * Replaces any parameter placeholders in a query with the value of that
   * parameter. Useful for debugging. Assumes anonymous parameters from
   * $params are are in the same order as specified in $query
   *
   * @param string $query The sql query with parameter placeholders
   * @param array $params The array of substitution parameters
   * @return string The interpolated query
   */
  public static function interpolateQuery($query, $params)
  {
    $keys = array();

    # build a regular expression for each parameter
    foreach ($params as $key => $value) {
      if (is_string($key)) {
        $keys[] = '/:' . $key . '/';
      } else {
        $keys[] = '/[?]/';
      }
    }

    $query = preg_replace($keys, $params, $query, 1, $count);

    #trigger_error('replaced '.$count.' keys');

    return $query;
  }
}


1			<?php
2
3			namespace DB;
4
5			use PDO as GlobalPDO;
6
7			class schema
8			{
9			/**
10			* Get ENUM or SET values.
11			*
12			* @return array
13			*/
14			public static function get_enumset_values(\DB\pdo $pdo, string $table, string $field)
15			{
16			$type = $pdo->query("SHOW COLUMNS FROM {$table} WHERE Field = '{$field}'")->row_array()['Type'];
17			$result = [];
18			if (preg_match("/^enum\(\'(.*)\'\)$/", $type, $matches)) {
19			$enum = explode("','", $matches[1]);
20
21			$result = $enum;
22			} elseif (preg_match("/^set\(\'(.*)\'\)$/", $type, $matches)) {
23			$set = explode("','", $matches[1]);
24
25			$result = $set;
26			}
27
28			return array_values(array_unique($result));
29			}
30
31			/**
32			* Modify ENUM or SET values.
33			* @see https://stackoverflow.com/questions/1501958/how-do-i-add-more-members-to-my-enum-type-column-in-mysql
34			* @return array
35			*/
36			public static function modify_enumset_values(\DB\pdo $pdo, string $table, string $field, array $newData)
37			{
38			for ($i = 0; $i < count($newData); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2020-07-06 12:38 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
39			$newData[$i] = "'$newData[$i]'";
40			}
41			$data = implode(', ', array_values(array_unique($newData)));
42			$sql = "ALTER TABLE `$table` MODIFY COLUMN `$field` SET($data) NOT NULL";
43			return $pdo->query($sql)->exec();
44			}
45
46			/**
47			* Replaces any parameter placeholders in a query with the value of that
48			* parameter. Useful for debugging. Assumes anonymous parameters from
49			* $params are are in the same order as specified in $query
50			*
51			* @param string $query The sql query with parameter placeholders
52			* @param array $params The array of substitution parameters
53			* @return string The interpolated query
54			*/
55			public static function interpolateQuery($query, $params)
56			{
57			$keys = array();
58
59			# build a regular expression for each parameter
60			foreach ($params as $key => $value) {
61			if (is_string($key)) {
62			$keys[] = '/:' . $key . '/';
63			} else {
64			$keys[] = '/[?]/';
65			}
66			}
67
68			$query = preg_replace($keys, $params, $query, 1, $count);
69
70			#trigger_error('replaced '.$count.' keys');
71
72			return $query;
73			}
74			}
75

dimaslanjaka / universal-framework

schema::modify_enumset_values() A last analyzed 2021-05-12 13:02 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

schema::modify_enumset_values() A
last analyzed 2021-05-12 13:02 UTC