EloquentAccountRepository::hasPermission() - Code Metrics - Inspection of "[WIP] Remove User's roles and permissions" - diglabby/doika - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#235)

by Alies

created 2019-02-20 20:24 UTC

EloquentAccountRepository::hasPermission() A

↳ Parent: EloquentAccountRepository

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	2
dl	0
loc	16
rs	10
c	0
b	0
f	0

<?php

namespace App\Repositories;

use Exception;
use Carbon\Carbon;
use App\Models\User;
use App\Models\SocialLogin;
use Illuminate\Support\Arr;
use Laravel\Socialite\AbstractUser;
use App\Exceptions\GeneralException;
use Illuminate\Support\Facades\Hash;
use App\Repositories\Contracts\UserRepository;
use Illuminate\Contracts\Auth\Authenticatable;
use App\Repositories\Contracts\AccountRepository;

/**
 * Class EloquentAccountRepository.
 */
class EloquentAccountRepository extends EloquentBaseRepository implements AccountRepository
{
    /**
     * @var UserRepository
     */
    protected $users;

    /**
     * EloquentUserRepository constructor.
     *
     * @param User                                       $user
     * @param \App\Repositories\Contracts\UserRepository $users
     *
     * @internal param \Mcamara\LaravelLocalization\LaravelLocalization
     *           $localization
     * @internal param \Illuminate\Contracts\Config\Repository $config
     */
    public function __construct(User $user, UserRepository $users)
    {
        parent::__construct($user);
        $this->users = $users;
    }

    /**
     * @param array $input
     *
     * @throws \Throwable
     * @throws \Exception
     *
     * @return \App\Models\User
     */
    public function register(array $input)
    {
        $user = $this->users->store(Arr::only($input, ['name', 'email', 'password']));

        return $user;
    }

    /**
     * @param Authenticatable $user
     *
     * @throws \App\Exceptions\GeneralException
     *
     * @return \App\Models\User
     */
    public function login(Authenticatable $user)
    {
        /* @var User $user */
        $user->last_access_at = Carbon::now();

        if (! $user->save()) {
            throw new GeneralException(__('exceptions.backend.users.update'));
        }

        return $user;
    }

    /**
     * @param              $provider
     * @param AbstractUser $data
     *
     * @throws \App\Exceptions\GeneralException
     *
     * @return User
     */
    public function findOrCreateSocial($provider, AbstractUser $data)
    {
        // Email can be not provided, so set default provider email.
        $user_email = $data->getEmail() ?: "{$data->getId()}@{$provider}.com";

        // Get user with this email or create new one.
        /** @var User $user */
        $user = $this->users->query()->whereEmail($user_email)->first();

        if (! $user) {

            // Registration is not enabled
            if (! config('account.can_register')) {
                throw new GeneralException(__('exceptions.frontend.auth.registration_disabled'));
            }

            $user = $this->users->store([
                'name'   => $data->getName(),
                'email'  => $user_email,
                'active' => true,
            ], true);
        }

        // Save new provider if needed
        if (! $user->getProvider($provider)) {
            $user->providers()->save(new SocialLogin([
                'provider'    => $provider,
                'provider_id' => $data->getId(),
            ]));
        }

        return $user;
    }

    /**
     * @param $input
     *
     * @throws \Illuminate\Database\Eloquent\MassAssignmentException
     * @throws \App\Exceptions\GeneralException
     *
     * @return mixed
     */
    public function update(array $input)
    {
        if (! config('account.updating_enabled')) {
            throw new GeneralException(__('exceptions.frontend.user.updating_disabled'));
        }

        /** @var User $user */
        $user = auth()->user();

        $user->fill(Arr::only($input, ['name', 'email', 'locale', 'timezone']));

        return $user->save();
    }

    /**
     * @param $oldPassword
     * @param $newPassword
     *
     * @throws \App\Exceptions\GeneralException
     *
     * @return mixed
     */
    public function changePassword($oldPassword, $newPassword)
    {
        if (! config('account.updating_enabled')) {
            throw new GeneralException(__('exceptions.frontend.user.updating_disabled'));
        }

        /** @var User $user */
        $user = auth()->user();

        if (empty($user->password) || Hash::check($oldPassword, $user->password)) {
            $user->password = Hash::make($newPassword);

            return $user->save();
        }

        throw new GeneralException(__('exceptions.frontend.user.password_mismatch'));
    }

    /**
     * @throws \App\Exceptions\GeneralException|Exception
     *
     * @return mixed
     */
    public function delete()
    {
        /** @var User $user */
        $user = auth()->user();

        if ($user->is_super_admin) {
            throw new GeneralException(__('exceptions.backend.users.first_user_cannot_be_destroyed'));
        }

        if (! $user->delete()) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            throw new GeneralException(__('exceptions.frontend.user.delete_account'));
        }

        return true;
    }
}


1			<?php
2
3			namespace App\Repositories;
4
5			use Exception;
6			use Carbon\Carbon;
7			use App\Models\User;
8			use App\Models\SocialLogin;
9			use Illuminate\Support\Arr;
10			use Laravel\Socialite\AbstractUser;
11			use App\Exceptions\GeneralException;
12			use Illuminate\Support\Facades\Hash;
13			use App\Repositories\Contracts\UserRepository;
14			use Illuminate\Contracts\Auth\Authenticatable;
15			use App\Repositories\Contracts\AccountRepository;
16
17			/**
18			* Class EloquentAccountRepository.
19			*/
20			class EloquentAccountRepository extends EloquentBaseRepository implements AccountRepository
21			{
22			/**
23			* @var UserRepository
24			*/
25			protected $users;
26
27			/**
28			* EloquentUserRepository constructor.
29			*
30			* @param User $user
31			* @param \App\Repositories\Contracts\UserRepository $users
32			*
33			* @internal param \Mcamara\LaravelLocalization\LaravelLocalization
34			* $localization
35			* @internal param \Illuminate\Contracts\Config\Repository $config
36			*/
37			public function __construct(User $user, UserRepository $users)
38			{
39			parent::__construct($user);
40			$this->users = $users;
41			}
42
43			/**
44			* @param array $input
45			*
46			* @throws \Throwable
47			* @throws \Exception
48			*
49			* @return \App\Models\User
50			*/
51			public function register(array $input)
52			{
53			$user = $this->users->store(Arr::only($input, ['name', 'email', 'password']));
54
55			return $user;
56			}
57
58			/**
59			* @param Authenticatable $user
60			*
61			* @throws \App\Exceptions\GeneralException
62			*
63			* @return \App\Models\User
64			*/
65			public function login(Authenticatable $user)
66			{
67			/* @var User $user */
68			$user->last_access_at = Carbon::now();
69
70			if (! $user->save()) {
71			throw new GeneralException(__('exceptions.backend.users.update'));
72			}
73
74			return $user;
75			}
76
77			/**
78			* @param $provider
79			* @param AbstractUser $data
80			*
81			* @throws \App\Exceptions\GeneralException
82			*
83			* @return User
84			*/
85			public function findOrCreateSocial($provider, AbstractUser $data)
86			{
87			// Email can be not provided, so set default provider email.
88			$user_email = $data->getEmail() ?: "{$data->getId()}@{$provider}.com";
89
90			// Get user with this email or create new one.
91			/** @var User $user */
92			$user = $this->users->query()->whereEmail($user_email)->first();
93
94			if (! $user) {
			0 ignored issues – show introduced 2019-01-23 20:01 UTC by Report Bug Copy Issue Report `$user` is of type `App\Models\User`, thus it always evaluated to `true`. Loading history...
95			// Registration is not enabled
96			if (! config('account.can_register')) {
97			throw new GeneralException(__('exceptions.frontend.auth.registration_disabled'));
98			}
99
100			$user = $this->users->store([
101			'name' => $data->getName(),
102			'email' => $user_email,
103			'active' => true,
104			], true);
105			}
106
107			// Save new provider if needed
108			if (! $user->getProvider($provider)) {
109			$user->providers()->save(new SocialLogin([
110			'provider' => $provider,
111			'provider_id' => $data->getId(),
112			]));
113			}
114
115			return $user;
116			}
117
118			/**
119			* @param $input
120			*
121			* @throws \Illuminate\Database\Eloquent\MassAssignmentException
122			* @throws \App\Exceptions\GeneralException
123			*
124			* @return mixed
125			*/
126			public function update(array $input)
127			{
128			if (! config('account.updating_enabled')) {
129			throw new GeneralException(__('exceptions.frontend.user.updating_disabled'));
130			}
131
132			/** @var User $user */
133			$user = auth()->user();
134
135			$user->fill(Arr::only($input, ['name', 'email', 'locale', 'timezone']));
136
137			return $user->save();
138			}
139
140			/**
141			* @param $oldPassword
142			* @param $newPassword
143			*
144			* @throws \App\Exceptions\GeneralException
145			*
146			* @return mixed
147			*/
148			public function changePassword($oldPassword, $newPassword)
149			{
150			if (! config('account.updating_enabled')) {
151			throw new GeneralException(__('exceptions.frontend.user.updating_disabled'));
152			}
153
154			/** @var User $user */
155			$user = auth()->user();
156
157			if (empty($user->password) \|\| Hash::check($oldPassword, $user->password)) {
158			$user->password = Hash::make($newPassword);
159
160			return $user->save();
161			}
162
163			throw new GeneralException(__('exceptions.frontend.user.password_mismatch'));
164			}
165
166			/**
167			* @throws \App\Exceptions\GeneralException\|Exception
168			*
169			* @return mixed
170			*/
171			public function delete()
172			{
173			/** @var User $user */
174			$user = auth()->user();
175
176			if ($user->is_super_admin) {
177			throw new GeneralException(__('exceptions.backend.users.first_user_cannot_be_destroyed'));
178			}
179
180			if (! $user->delete()) {
			0 ignored issues – show Bug Best Practice introduced 2019-01-23 20:01 UTC by Report Bug Copy Issue Report The expression `$user->delete()` of type `boolean\|null` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
181			throw new GeneralException(__('exceptions.frontend.user.delete_account'));
182			}
183
184			return true;
185			}
186			}
187

diglabby / doika

Pull Request — dev (#235)

EloquentAccountRepository::hasPermission() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like