Passed
Pull Request — master (#15)
by Steven
02:37
created

DelayedQuote   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 49
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 76.92%

Importance

Changes 0
Metric Value
wmc 6
lcom 1
cbo 2
dl 49
loc 49
ccs 10
cts 13
cp 0.7692
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 4 4 1
A getFullEndpoint() 6 6 2
A validateParams() 6 6 2
A oddLot() 6 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Digitonic\IexCloudSdk\Stocks;
4
5
use Digitonic\IexCloudSdk\Contracts\IEXCloud;
6
use Digitonic\IexCloudSdk\Exceptions\WrongData;
7
use Digitonic\IexCloudSdk\Requests\BaseRequest;
8
9 View Code Duplication
class DelayedQuote extends BaseRequest
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
10
{
11
    const ENDPOINT = 'stock/{symbol}/delayed-quote';
12
13
    /**
14
     * @var bool
15
     */
16
    protected $oddLot = false;
17
18
    /**
19
     * Create constructor.
20
     *
21
     * @param  IEXCloud  $api
22
     */
23 3
    public function __construct(IEXCloud $api)
24
    {
25 3
        parent::__construct($api);
26 3
    }
27
28
    /**
29
     * If the oddLot property is set, add it to the end of the endpoint string.
30
     *
31
     * @return string
32
     */
33 1
    protected function getFullEndpoint(): string
34
    {
35 1
        $endpoint = str_replace('{symbol}', $this->symbol, self::ENDPOINT);
36
37 1
        return $this->oddLot ? "$endpoint/oddLot=$this->oddLot" : $endpoint;
38
    }
39
40
    /**
41
     * @return bool|void
42
     * @throws WrongData
43
     */
44 2
    protected function validateParams(): void
45
    {
46 2
        if (empty($this->symbol)) {
47 1
            throw WrongData::invalidValuesProvided('Please provide a symbol to query!');
48
        }
49 1
    }
50
51
    public function oddLot(bool $oddLot = true): self
52
    {
53
        $this->oddLot = $oddLot;
54
55
        return $this;
56
    }
57
}
58