Digitonic\ApiTestSuite\Concerns\AssertsErrorFormat

Complexity

Total Complexity

1

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	assertErrorFormat()	0	20	1

<?php

namespace Digitonic\ApiTestSuite\Concerns;

use Illuminate\Support\Facades\View;
use Digitonic\ApiTestSuite\TestResponse;

trait AssertsErrorFormat
{
    /**
     * The template used allows regular expressions, e.g. in the default 400.blade.php template
     *
     * @param TestResponse $response
     * @param $status
     * @param array $data
     */
    protected function assertErrorFormat(TestResponse $response, $status, $data = [])
    {
        $response->assertStatus($status);
        $this->checkRequiredResponseHeaders($response);

It seems like checkRequiredResponseHeaders() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertMatchesRegularExpression(

It seems like assertMatchesRegularExpression() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            "/" . trim(
                View::file(

It seems like Illuminate\Support\Facades\View::file(config('digitonic.api-test-suite.templates.base_path') . 'errors/' . $status . '.blade.php', $data)->with(array('exception' => $response->exception))->render() can also be of type array; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

                    config('digitonic.api-test-suite.templates.base_path') . 'errors/' . $status . '.blade.php',
                    $data
                )->with(

                        ['exception' => $response->exception

The property exception does not exist on Digitonic\ApiTestSuite\TestResponse. Since you implemented __get, consider adding a @property annotation.

                    ]
                )->render()

) . "/",
            $response->getContent(),

The method getContent() does not exist on Digitonic\ApiTestSuite\TestResponse. Since you implemented __call, consider adding a @method annotation.

            'Error response structure doesn\'t follow the template set up in '
            .config('digitonic.api-test-suite.templates.base_path').' errors/{errorStatusCode}.blade.php.'
        );
    }
}