Issues in generate_tests.php (master) - Issues in master - digitickets/lalit - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/scripts/generate_tests.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


use LaLit\Array2XML;
use LaLit\XML2Array;

require_once __DIR__.'/../../vendor/autoload.php';

/**
 * @param string|string[] $tags
 *
 * @return array
 */
function generateTags($tags)
{
    if (is_array($tags)) {
        $tag = array_shift($tags);
    } else {
        $tag = $tags;
    }

    $attributeSet = [
        'No attributes' => '',
        'Empty attribute' => ' attribute1=""',
        'Encoded attribute' => ' attribute2="&lt;important&gt;"',
        'Simple attribute' => ' attribute3="1"',
        'Quoted and encoded attribute' => ' attribute4="\'&lt;important&gt;\'"',
        'Empty quoted attribute' => ' attribute5="\'\'"',
        'Null attribute' => ' attribute6="null"',
        'All attributes' => ' attribute1="" attribute2="&lt;important&gt;" attribute3="1" attribute4="\'&lt;important&gt;\'" attribute5="\'\'"  attribute6="null"',
    ];

    $cDataSet = [
        'Null value' => 'null',
        'Empty value' => '',
        'Simple value' => 'normal',
        'Encoded value' => '&lt;escaped&gt;',
        'Empty CDATA' => '<![CDATA[]]>',
        'CDATA with tagged value' => '<![CDATA[<very_important>]]>',
    ];

    if (is_array($tags) && count($tags) > 0) {
        $cDataSet = array_merge($cDataSet, generateTags($tags));
    }

    $results = [];

    foreach ($attributeSet as $attributeType => $attribute) {
        foreach ($cDataSet as $cdataType => $cdata) {
            if (!is_array($tag)) {
                $results[$attributeType.' - '.$cdataType] = "<{$tag}{$attribute}>{$cdata}</{$tag}>";
            } else {
                $result = '';
                foreach (range(1, $tag[1]) as $repeat) {
                    $result .= "<{$tag[0]}{$attribute}>{$cdata}</{$tag[0]}>";
                }
                $results[$attributeType.' - '.$cdataType.' with '.$tag[1].' nodes'] = $result;
            }
        }
    }

    return $results;
}

$docs = [];

$docs = array_merge($docs, generateTags(['root']));
$docs = array_merge($docs, generateTags(['root', 'node']));
$docs = array_merge($docs, generateTags(['root', 'collection', ['node', 2]]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
$docs = array_unique($docs);

$testData = [];
foreach ($docs as $key => $value) {
    $php = XML2Array::createArray($value);

    $testData[$key] = [
        unserialize(str_replace('s:4:"null";', 'N;', serialize($php))),
        str_replace('null', '', Array2XML::createXML('root', $php['root'])->saveXML()),
        $key,
    ];
}

file_put_contents(__DIR__.'/../files/testData.inc', '<?php return '.var_export(array_values($testData), true).';');


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-17 14:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 6. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			use LaLit\Array2XML;
4			use LaLit\XML2Array;
5
6			require_once __DIR__.'/../../vendor/autoload.php';
7
8			/**
9			* @param string\|string[] $tags
10			*
11			* @return array
12			*/
13			function generateTags($tags)
14			{
15			if (is_array($tags)) {
16			$tag = array_shift($tags);
17			} else {
18			$tag = $tags;
19			}
20
21			$attributeSet = [
22			'No attributes' => '',
23			'Empty attribute' => ' attribute1=""',
24			'Encoded attribute' => ' attribute2="<important>"',
25			'Simple attribute' => ' attribute3="1"',
26			'Quoted and encoded attribute' => ' attribute4="\'<important>\'"',
27			'Empty quoted attribute' => ' attribute5="\'\'"',
28			'Null attribute' => ' attribute6="null"',
29			'All attributes' => ' attribute1="" attribute2="<important>" attribute3="1" attribute4="\'<important>\'" attribute5="\'\'" attribute6="null"',
30			];
31
32			$cDataSet = [
33			'Null value' => 'null',
34			'Empty value' => '',
35			'Simple value' => 'normal',
36			'Encoded value' => '<escaped>',
37			'Empty CDATA' => '<![CDATA[]]>',
38			'CDATA with tagged value' => '<![CDATA[<very_important>]]>',
39			];
40
41			if (is_array($tags) && count($tags) > 0) {
42			$cDataSet = array_merge($cDataSet, generateTags($tags));
43			}
44
45			$results = [];
46
47			foreach ($attributeSet as $attributeType => $attribute) {
48			foreach ($cDataSet as $cdataType => $cdata) {
49			if (!is_array($tag)) {
50			$results[$attributeType.' - '.$cdataType] = "<{$tag}{$attribute}>{$cdata}</{$tag}>";
51			} else {
52			$result = '';
53			foreach (range(1, $tag[1]) as $repeat) {
54			$result .= "<{$tag[0]}{$attribute}>{$cdata}</{$tag[0]}>";
55			}
56			$results[$attributeType.' - '.$cdataType.' with '.$tag[1].' nodes'] = $result;
57			}
58			}
59			}
60
61			return $results;
62			}
63
64			$docs = [];
65
66			$docs = array_merge($docs, generateTags(['root']));
67			$docs = array_merge($docs, generateTags(['root', 'node']));
68			$docs = array_merge($docs, generateTags(['root', 'collection', ['node', 2]]));
			0 ignored issues – show Documentation introduced 2016-11-17 14:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('root', 'collection', array('node', 2))` is of type `array<integer,string\|arr...,\"1\":\"integer\"}>"}>`, but the function expects a `string\|array<integer,string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
69			$docs = array_unique($docs);
70
71			$testData = [];
72			foreach ($docs as $key => $value) {
73			$php = XML2Array::createArray($value);
74
75			$testData[$key] = [
76			unserialize(str_replace('s:4:"null";', 'N;', serialize($php))),
77			str_replace('null', '', Array2XML::createXML('root', $php['root'])->saveXML()),
78			$key,
79			];
80			}
81
82			file_put_contents(__DIR__.'/../files/testData.inc', '<?php return '.var_export(array_values($testData), true).';');
83

digitickets / lalit

Issues (9)

Security Analysis no request data

tests/scripts/generate_tests.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like