MainLaLitTest::testXMLToArray() - Code Metrics - digitickets/lalit - Measure and Improve Code Quality continuously with Scrutinizer

MainLaLitTest::testXMLToArray() A
last analyzed 2016-11-17 14:01 UTC

↳ Parent: MainLaLitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	10
nc	1
nop	3
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php

namespace LaLit;

class MainLaLitTest extends \PHPUnit_Framework_TestCase
{
    public function provideTestData()
    {
        return include __DIR__.'/files/testData.inc';
    }

    /**
     * @dataProvider provideTestData
     *
     * @param string $php
     * @param string $xml
     * @param string $structure
     */
    public function testArrayToXML($php, $xml, $structure)
    {
        $actualResults = Array2XML::createXML('root', $php['root'])->saveXML();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $expectedResults = $xml;

        $this->assertEquals($expectedResults, $actualResults, $structure);
    }

    /**
     * @dataProvider provideTestData
     *
     * @param string $php
     * @param string $xmlString
     * @param string $structure
     */
    public function testXMLToArray($php, $xmlString, $structure)
    {
        $xmlDOM = new \DOMDocument(1.0, 'UTF-8');
        $xmlDOM->xmlStandalone = false;
        $xmlDOM->preserveWhiteSpace = false;
        $xmlDOM->loadXML($xmlString);
        $xmlDOM->formatOutput = true;

        $xmlStringResults = XML2Array::createArray($xmlString);
        $xmlDOMResults = XML2Array::createArray($xmlDOM);

        $this->assertEquals($php, $xmlStringResults, $structure);
        $this->assertEquals($php, $xmlDOMResults, $structure);
    }
}


1			<?php
2
3			namespace LaLit;
4
5			class MainLaLitTest extends \PHPUnit_Framework_TestCase
6			{
7			public function provideTestData()
8			{
9			return include __DIR__.'/files/testData.inc';
10			}
11
12			/**
13			* @dataProvider provideTestData
14			*
15			* @param string $php
16			* @param string $xml
17			* @param string $structure
18			*/
19			public function testArrayToXML($php, $xml, $structure)
20			{
21			$actualResults = Array2XML::createXML('root', $php['root'])->saveXML();
			0 ignored issues – show Documentation introduced 2016-11-17 14:01 UTC by Report Bug Copy Issue Report `$php['root']` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
22			$expectedResults = $xml;
23
24			$this->assertEquals($expectedResults, $actualResults, $structure);
25			}
26
27			/**
28			* @dataProvider provideTestData
29			*
30			* @param string $php
31			* @param string $xmlString
32			* @param string $structure
33			*/
34			public function testXMLToArray($php, $xmlString, $structure)
35			{
36			$xmlDOM = new \DOMDocument(1.0, 'UTF-8');
37			$xmlDOM->xmlStandalone = false;
38			$xmlDOM->preserveWhiteSpace = false;
39			$xmlDOM->loadXML($xmlString);
40			$xmlDOM->formatOutput = true;
41
42			$xmlStringResults = XML2Array::createArray($xmlString);
43			$xmlDOMResults = XML2Array::createArray($xmlDOM);
44
45			$this->assertEquals($php, $xmlStringResults, $structure);
46			$this->assertEquals($php, $xmlDOMResults, $structure);
47			}
48			}
49

digitickets / lalit

MainLaLitTest::testXMLToArray() A last analyzed 2016-11-17 14:01 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MainLaLitTest::testXMLToArray() A
last analyzed 2016-11-17 14:01 UTC