Issues in Desk.php (master) - Issues in master - digitalequation/teamwork - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Services/Desk.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace DigitalEquation\Teamwork\Services;

use DigitalEquation\Teamwork\Exceptions\TeamworkHttpException;
use DigitalEquation\Teamwork\Exceptions\TeamworkInboxException;
use DigitalEquation\Teamwork\Exceptions\TeamworkUploadException;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\Psr7\Stream;
use Illuminate\Support\Facades\File;

class Desk
{
    /**
     * @var \GuzzleHttp\Client
     */
    private Client $client;


    /**
     * Desk constructor.
     *
     * @param \GuzzleHttp\Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Return an inbox by name.
     *
     * @param string $name
     *
     * @return array
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkInboxException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \JsonException
     */
    public function inbox($name): array
    {
        try {
            /** @var Response $response */
            $response = $this->client->get('inboxes.json');
            /** @var Stream $body */
            $body    = $response->getBody();
            $inboxes = json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);

            $inbox = collect($inboxes['inboxes'])->first(
                function ($inbox) use ($name) {
                    return $inbox['name'] === $name;
                }
            );

            if (! $inbox) {
                throw new TeamworkInboxException("No inbox found with the name: $name!", 400);
            }

            return $inbox;
        } catch (ClientException $e) {
            throw new TeamworkHttpException($e->getMessage(), 400);
        }
    }

    /**
     * Get teamwork desk inboxes.
     *
     * @return array
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \JsonException
     */
    public function inboxes(): array
    {
        try {
            /** @var Response $response */
            $response = $this->client->get('inboxes.json');
            /** @var Stream $body */
            $body = $response->getBody();

            return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
        } catch (ClientException $e) {
            throw new TeamworkHttpException($e->getMessage(), 400);
        }
    }

    /**
     * Return the current client info.
     *
     * @return array
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \JsonException
     */
    public function me(): array
    {
        try {
            /** @var Response $response */
            $response = $this->client->get('me.json');
            /** @var Stream $body */
            $body = $response->getBody();

            return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
        } catch (ClientException $e) {
            throw new TeamworkHttpException($e->getMessage(), 400);
        }
    }

    /**
     * Update the customer, based on customerId.
     *
     * @param array $data = ['customerId', 'email', 'firstName', 'lastName', 'phone', 'mobile'];
     *
     * @return array
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \JsonException
     */
    public function postCustomer(array $data): array
    {
        try {
            /** @var Response $response */
            $response = $this->client->put('customers/'.$data['customerId'].'.json', [
                'json' => $data,
            ]);

            /** @var Stream $body */
            $body = $response->getBody();

            return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
        } catch (ClientException $e) {
            throw new TeamworkHttpException($e->getMessage(), 400);
        }
    }

    /**
     * Upload file to teamwork desk.
     *
     * @param $userId
     * @param $file
     *
     * @return array
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
     * @throws \DigitalEquation\Teamwork\Exceptions\TeamworkUploadException
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \JsonException
     */
    public function upload($userId, $file): array
    {
        if (empty($file)) {
            throw new TeamworkUploadException('No file provided.', 400);
        }

        $filename  = $file->getClientOriginalName();
        $extension = $file->getClientOriginalExtension();
        $path      = sys_get_temp_dir();
        $temp      = $file->move($path, $filename);
        $stream    = fopen($temp->getPathName(), 'rb');

        try {
            /** @var Response $response */
            $response = $this->client->post('upload/attachment', [
                'multipart' => [
                    [
                        'name'     => 'file',
                        'contents' => $stream,
                    ], [
                        'name'     => 'userId',
                        'contents' => $userId,
                    ],
                ],
            ]);
            /** @var Stream $body */
            $body = $response->getBody();
            $body = json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);

            if (! empty($stream)) {
                File::delete($temp->getPathName());
            }

            return [
                'id'        => $body['attachment']['id'],
                'url'       => $body['attachment']['downloadURL'],
                'extension' => $extension,
                'name'      => $body['attachment']['filename'],
                'size'      => $body['attachment']['size'],
            ];
        } catch (ClientException $e) {
            throw new TeamworkHttpException($e->getMessage(), 400);
        }
    }
}


1			<?php
2
3			namespace DigitalEquation\Teamwork\Services;
4
5			use DigitalEquation\Teamwork\Exceptions\TeamworkHttpException;
6			use DigitalEquation\Teamwork\Exceptions\TeamworkInboxException;
7			use DigitalEquation\Teamwork\Exceptions\TeamworkUploadException;
8			use GuzzleHttp\Client;
9			use GuzzleHttp\Exception\ClientException;
10			use GuzzleHttp\Psr7\Response;
11			use GuzzleHttp\Psr7\Stream;
12			use Illuminate\Support\Facades\File;
13
14			class Desk
15			{
16			/**
17			* @var \GuzzleHttp\Client
18			*/
19			private Client $client;
			0 ignored issues – show Bug introduced 2020-09-16 07:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
20
21			/**
22			* Desk constructor.
23			*
24			* @param \GuzzleHttp\Client $client
25			*/
26			public function __construct(Client $client)
27			{
28			$this->client = $client;
29			}
30
31			/**
32			* Return an inbox by name.
33			*
34			* @param string $name
35			*
36			* @return array
37			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
38			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkInboxException
39			* @throws \GuzzleHttp\Exception\GuzzleException
40			* @throws \JsonException
41			*/
42			public function inbox($name): array
43			{
44			try {
45			/** @var Response $response */
46			$response = $this->client->get('inboxes.json');
47			/** @var Stream $body */
48			$body = $response->getBody();
49			$inboxes = json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
50
51			$inbox = collect($inboxes['inboxes'])->first(
52			function ($inbox) use ($name) {
53			return $inbox['name'] === $name;
54			}
55			);
56
57			if (! $inbox) {
58			throw new TeamworkInboxException("No inbox found with the name: $name!", 400);
59			}
60
61			return $inbox;
62			} catch (ClientException $e) {
63			throw new TeamworkHttpException($e->getMessage(), 400);
64			}
65			}
66
67			/**
68			* Get teamwork desk inboxes.
69			*
70			* @return array
71			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
72			* @throws \GuzzleHttp\Exception\GuzzleException
73			* @throws \JsonException
74			*/
75			public function inboxes(): array
76			{
77			try {
78			/** @var Response $response */
79			$response = $this->client->get('inboxes.json');
80			/** @var Stream $body */
81			$body = $response->getBody();
82
83			return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
84			} catch (ClientException $e) {
85			throw new TeamworkHttpException($e->getMessage(), 400);
86			}
87			}
88
89			/**
90			* Return the current client info.
91			*
92			* @return array
93			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
94			* @throws \GuzzleHttp\Exception\GuzzleException
95			* @throws \JsonException
96			*/
97			public function me(): array
98			{
99			try {
100			/** @var Response $response */
101			$response = $this->client->get('me.json');
102			/** @var Stream $body */
103			$body = $response->getBody();
104
105			return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
106			} catch (ClientException $e) {
107			throw new TeamworkHttpException($e->getMessage(), 400);
108			}
109			}
110
111			/**
112			* Update the customer, based on customerId.
113			*
114			* @param array $data = ['customerId', 'email', 'firstName', 'lastName', 'phone', 'mobile'];
115			*
116			* @return array
117			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
118			* @throws \GuzzleHttp\Exception\GuzzleException
119			* @throws \JsonException
120			*/
121			public function postCustomer(array $data): array
122			{
123			try {
124			/** @var Response $response */
125			$response = $this->client->put('customers/'.$data['customerId'].'.json', [
126			'json' => $data,
127			]);
128
129			/** @var Stream $body */
130			$body = $response->getBody();
131
132			return json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
133			} catch (ClientException $e) {
134			throw new TeamworkHttpException($e->getMessage(), 400);
135			}
136			}
137
138			/**
139			* Upload file to teamwork desk.
140			*
141			* @param $userId
142			* @param $file
143			*
144			* @return array
145			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkHttpException
146			* @throws \DigitalEquation\Teamwork\Exceptions\TeamworkUploadException
147			* @throws \GuzzleHttp\Exception\GuzzleException
148			* @throws \JsonException
149			*/
150			public function upload($userId, $file): array
151			{
152			if (empty($file)) {
153			throw new TeamworkUploadException('No file provided.', 400);
154			}
155
156			$filename = $file->getClientOriginalName();
157			$extension = $file->getClientOriginalExtension();
158			$path = sys_get_temp_dir();
159			$temp = $file->move($path, $filename);
160			$stream = fopen($temp->getPathName(), 'rb');
161
162			try {
163			/** @var Response $response */
164			$response = $this->client->post('upload/attachment', [
165			'multipart' => [
166			[
167			'name' => 'file',
168			'contents' => $stream,
169			], [
170			'name' => 'userId',
171			'contents' => $userId,
172			],
173			],
174			]);
175			/** @var Stream $body */
176			$body = $response->getBody();
177			$body = json_decode($body->getContents(), true, 512, JSON_THROW_ON_ERROR);
178
179			if (! empty($stream)) {
180			File::delete($temp->getPathName());
181			}
182
183			return [
184			'id' => $body['attachment']['id'],
185			'url' => $body['attachment']['downloadURL'],
186			'extension' => $extension,
187			'name' => $body['attachment']['filename'],
188			'size' => $body['attachment']['size'],
189			];
190			} catch (ClientException $e) {
191			throw new TeamworkHttpException($e->getMessage(), 400);
192			}
193			}
194			}
195

digitalequation / teamwork

Issues (5)

Security Analysis not enabled

src/Services/Desk.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like