IndexCommand::indexData() - Code Metrics - digiaonline/lumen-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

IndexCommand::indexData() B
last analyzed 2019-10-17 08:46 UTC

↳ Parent: IndexCommand

Complexity

Conditions	7
Paths	20

Size

Total Lines	58
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	34
c	1
b	0
f	0
dl	0
loc	58
rs	8.4426
cc	7
nc	20
nop	1

How to fix Long Method

<?php namespace Nord\Lumen\Elasticsearch\Console;

use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkAction;
use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkQuery;
use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkResponseAggregator;
use Nord\Lumen\Elasticsearch\IndexNamePrefixer;

abstract class IndexCommand extends AbstractCommand
{

    /**
     * The number of items to process before updating the progress bar
     */
    const PROGRESS_BAR_REDRAW_FREQUENCY = 50;

    /**
     * @return array
     */
    abstract public function getData();

    /**
     * @return string
     */
    abstract public function getIndex();

    /**
     * @return string
     */
    abstract public function getType();

    /**
     * @param mixed $item
     *
     * @return array
     */
    abstract public function getItemBody($item);

    /**
     * @param mixed $item
     *
     * @return string
     */
    abstract public function getItemId($item);

    /**
     * @param mixed $item
     *
     * @return string|null
     */
    abstract public function getItemParent($item);

    /**
     * @inheritdoc
     */
    public function handle()
    {
        $this->indexData($this->getIndex());
    }

    /**
     * @param string $indexName
     */
    protected function indexData(string $indexName): void
    {
        $indexName = IndexNamePrefixer::getPrefixedIndexName($indexName);
        
        $this->info(sprintf('Indexing data of type "%s" into "%s"', $this->getType(), $indexName));

        $data = $this->getData();

        $bar = $this->output->createProgressBar($this->getCount());
        $bar->setRedrawFrequency($this->getProgressBarRedrawFrequency());

        $bulkQuery              = new BulkQuery($this->getBulkSize());
        $bulkResponseAggregator = new BulkResponseAggregator();

        foreach ($data as $item) {
            $action = new BulkAction();

            $meta = [
                '_index' => $indexName,
                '_type'  => $this->getType(),
                '_id'    => $this->getItemId($item),
            ];

            if (($parent = $this->getItemParent($item)) !== null) {
                $meta['_parent'] = $parent;
            }

            $action->setAction(BulkAction::ACTION_INDEX, $meta)
                   ->setBody($this->getItemBody($item));

            $bulkQuery->addAction($action);

            if ($bulkQuery->isReady()) {
                $response = $this->elasticsearchService->bulk($bulkQuery->toArray());
                $bulkQuery->reset();
                $bulkResponseAggregator->addResponse($response);
            }

            $bar->advance();
        }

        if ($bulkQuery->hasItems()) {
            $response = $this->elasticsearchService->bulk($bulkQuery->toArray());
            $bulkResponseAggregator->addResponse($response);
        }

        $bar->finish();

        $hasErrors = $bulkResponseAggregator->hasErrors();
        if ($hasErrors) {
            $this->info("\n");
            $errors = $bulkResponseAggregator->getErrors();
            foreach ($errors as $error) {
                $this->error($error);
            }
        }

        $this->info("\nDone!");
    }

    /**
     * @return int the bulk size (for bulk indexing)
     */
    protected function getBulkSize()
    {
        return BulkQuery::BULK_SIZE_DEFAULT;
    }

    /**
     * @return int the progress bar redraw frequency
     */
    protected function getProgressBarRedrawFrequency()
    {
        return self::PROGRESS_BAR_REDRAW_FREQUENCY;
    }

    /**
     * Get the total count.
     *
     * @return int
     */
    protected function getCount()
    {
        return count($this->getData());
    }
}


1			<?php namespace Nord\Lumen\Elasticsearch\Console;
2
3			use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkAction;
4			use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkQuery;
5			use Nord\Lumen\Elasticsearch\Documents\Bulk\BulkResponseAggregator;
6			use Nord\Lumen\Elasticsearch\IndexNamePrefixer;
7
8			abstract class IndexCommand extends AbstractCommand
9			{
10
11			/**
12			* The number of items to process before updating the progress bar
13			*/
14			const PROGRESS_BAR_REDRAW_FREQUENCY = 50;
15
16			/**
17			* @return array
18			*/
19			abstract public function getData();
20
21			/**
22			* @return string
23			*/
24			abstract public function getIndex();
25
26			/**
27			* @return string
28			*/
29			abstract public function getType();
30
31			/**
32			* @param mixed $item
33			*
34			* @return array
35			*/
36			abstract public function getItemBody($item);
37
38			/**
39			* @param mixed $item
40			*
41			* @return string
42			*/
43			abstract public function getItemId($item);
44
45			/**
46			* @param mixed $item
47			*
48			* @return string\|null
49			*/
50			abstract public function getItemParent($item);
51
52			/**
53			* @inheritdoc
54			*/
55			public function handle()
56			{
57			$this->indexData($this->getIndex());
58			}
59
60			/**
61			* @param string $indexName
62			*/
63			protected function indexData(string $indexName): void
64			{
65			$indexName = IndexNamePrefixer::getPrefixedIndexName($indexName);
66
67			$this->info(sprintf('Indexing data of type "%s" into "%s"', $this->getType(), $indexName));
68
69			$data = $this->getData();
70
71			$bar = $this->output->createProgressBar($this->getCount());
72			$bar->setRedrawFrequency($this->getProgressBarRedrawFrequency());
73
74			$bulkQuery = new BulkQuery($this->getBulkSize());
75			$bulkResponseAggregator = new BulkResponseAggregator();
76
77			foreach ($data as $item) {
78			$action = new BulkAction();
79
80			$meta = [
81			'_index' => $indexName,
82			'_type' => $this->getType(),
83			'_id' => $this->getItemId($item),
84			];
85
86			if (($parent = $this->getItemParent($item)) !== null) {
87			$meta['_parent'] = $parent;
88			}
89
90			$action->setAction(BulkAction::ACTION_INDEX, $meta)
91			->setBody($this->getItemBody($item));
92
93			$bulkQuery->addAction($action);
94
95			if ($bulkQuery->isReady()) {
96			$response = $this->elasticsearchService->bulk($bulkQuery->toArray());
97			$bulkQuery->reset();
98			$bulkResponseAggregator->addResponse($response);
99			}
100
101			$bar->advance();
102			}
103
104			if ($bulkQuery->hasItems()) {
105			$response = $this->elasticsearchService->bulk($bulkQuery->toArray());
106			$bulkResponseAggregator->addResponse($response);
107			}
108
109			$bar->finish();
110
111			$hasErrors = $bulkResponseAggregator->hasErrors();
112			if ($hasErrors) {
113			$this->info("\n");
114			$errors = $bulkResponseAggregator->getErrors();
115			foreach ($errors as $error) {
116			$this->error($error);
117			}
118			}
119
120			$this->info("\nDone!");
121			}
122
123			/**
124			* @return int the bulk size (for bulk indexing)
125			*/
126			protected function getBulkSize()
127			{
128			return BulkQuery::BULK_SIZE_DEFAULT;
129			}
130
131			/**
132			* @return int the progress bar redraw frequency
133			*/
134			protected function getProgressBarRedrawFrequency()
135			{
136			return self::PROGRESS_BAR_REDRAW_FREQUENCY;
137			}
138
139			/**
140			* Get the total count.
141			*
142			* @return int
143			*/
144			protected function getCount()
145			{
146			return count($this->getData());
147			}
148			}
149

digiaonline / lumen-elasticsearch

IndexCommand::indexData() B last analyzed 2019-10-17 08:46 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

IndexCommand::indexData() B
last analyzed 2019-10-17 08:46 UTC