Issues (4)

src/CorsMiddleware.php (1 issue)

Labels
Severity
1
<?php namespace Nord\Lumen\Cors;
2
3
use Closure;
4
use Nord\Lumen\Cors\Contracts\CorsService;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Nord\Lumen\Cors\CorsService. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
5
use Illuminate\Http\Request;
6
7
class CorsMiddleware
8
{
9
10
    /**
11
     * @var CorsService
12
     */
13
    private $service;
14
15
16
    /**
17
     * CorsMiddleware constructor.
18
     *
19
     * @param CorsService $service
20
     */
21
    public function __construct(CorsService $service)
22
    {
23
        $this->service = $service;
24
    }
25
26
27
    /**
28
     * Run the request filter.
29
     *
30
     * @param  Request $request
31
     * @param  Closure $next
32
     *
33
     * @return mixed
34
     */
35
    public function handle(Request $request, Closure $next)
36
    {
37
        if (!$this->service->isCorsRequest($request)) {
38
            return $next($request);
39
        }
40
41
        if ($this->service->isPreflightRequest($request)) {
42
            return $this->service->handlePreflightRequest($request);
43
        }
44
45
        return $this->service->handleRequest($request, $next($request));
46
    }
47
}
48