digiaonline / graphql-php

src/Validation/Rule/KnownFragmentNamesRule.php

<?php

namespace Digia\GraphQL\Validation\Rule;

use Digia\GraphQL\Language\Node\FragmentSpreadNode;
use Digia\GraphQL\Language\Visitor\VisitorResult;
use Digia\GraphQL\Validation\ValidationException;
use function Digia\GraphQL\Validation\unknownFragmentMessage;

/**
 * Known fragment names
 *
 * A GraphQL document is only valid if all `...Fragment` fragment spreads refer
 * to fragments defined in the same document.
 */
class KnownFragmentNamesRule extends AbstractRule
{
    /**
     * @inheritdoc
     */
    public function enterFragmentSpread(FragmentSpreadNode $node): VisitorResult
    {
        $fragmentName = $node->getNameValue();
        $fragment     = $this->context->getFragment($fragmentName);

It seems like $fragmentName can also be of type null; however, parameter $name of Digia\GraphQL\Validation\ValidationContextInterface::getFragment() does only seem to accept string, maybe add an additional type check?

        if (null === $fragment) {
            $this->context->reportError(
                new ValidationException(unknownFragmentMessage($fragmentName), [$node->getName()])

It seems like $fragmentName can also be of type null; however, parameter $fragmentName of Digia\GraphQL\Validation\unknownFragmentMessage() does only seem to accept string, maybe add an additional type check?

            );
        }

        return new VisitorResult($node);
    }
}