digiaonline /
graphql-php
| Conditions | 24 |
| Paths | 87 |
| Total Lines | 128 |
| Code Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 225 | private function coerceValue($value, $type, $blameNode, ?array $path = null): CoercedValue |
||
| 226 | { |
||
| 227 | if ($type instanceof NonNullType) { |
||
| 228 | if (empty($value)) { |
||
| 229 | return new CoercedValue(null, [ |
||
| 230 | $this->buildCoerceException( |
||
| 231 | sprintf('Expected non-nullable type %s! not to be null', $type->getOfType()->getName()), |
||
| 232 | $blameNode, |
||
| 233 | $path |
||
| 234 | ) |
||
| 235 | ]); |
||
| 236 | } |
||
| 237 | return $this->coerceValue($value, $type->getOfType(), $blameNode, $path); |
||
| 238 | } |
||
| 239 | |||
| 240 | if (empty($value)) { |
||
| 241 | return new CoercedValue(null, null); |
||
| 242 | } |
||
| 243 | |||
| 244 | if ($type instanceof ScalarType) { |
||
| 245 | try { |
||
| 246 | $parseResult = $type->parseValue($value); |
||
| 247 | if (empty($parseResult)) { |
||
| 248 | return new CoercedValue(null, [ |
||
| 249 | new GraphQLException(sprintf('Expected type %s', $type->getName())) |
||
| 250 | ]); |
||
| 251 | } |
||
| 252 | return new CoercedValue($parseResult, null); |
||
| 253 | } catch (\Exception $ex) { |
||
| 254 | //@TODO Check exception message |
||
| 255 | return new CoercedValue(null, [ |
||
| 256 | new GraphQLException(sprintf('Expected type %s', $type->getName())) |
||
| 257 | ]); |
||
| 258 | } |
||
| 259 | } |
||
| 260 | |||
| 261 | if ($type instanceof EnumType) { |
||
| 262 | if (is_string($value)) { |
||
| 263 | $enumValue = $type->getValue($value); |
||
| 264 | if ($enumValue !== null) { |
||
| 265 | return new CoercedValue($enumValue, null); |
||
| 266 | } |
||
| 267 | } |
||
| 268 | $suggestions = suggestionList((string)$value, array_map(function (EnumValue $enumValue) { |
||
| 269 | return $enumValue->getName(); |
||
| 270 | }, $type->getValues())); |
||
| 271 | |||
| 272 | //@TODO throw proper error |
||
| 273 | } |
||
| 274 | |||
| 275 | if ($type instanceof ListType) { |
||
| 276 | $itemType = $type->getOfType(); |
||
| 277 | if (is_array($value) || $value instanceof \Traversable) { |
||
| 278 | $errors = []; |
||
| 279 | $coercedValues = []; |
||
| 280 | foreach ($value as $index => $itemValue) { |
||
| 281 | $coercedValue = $this->coerceValue( |
||
| 282 | $itemValue, |
||
| 283 | $itemType, |
||
| 284 | $blameNode, |
||
| 285 | [$path, $index] |
||
| 286 | ); |
||
| 287 | |||
| 288 | if ($coercedValue->hasErrors()) { |
||
| 289 | $errors = array_merge($errors, $coercedValue->getErrors()); |
||
| 290 | } else { |
||
| 291 | $coercedValues[] = $coercedValue->getValue(); |
||
| 292 | } |
||
| 293 | } |
||
| 294 | |||
| 295 | return new CoercedValue($coercedValues, $errors); |
||
| 296 | } |
||
| 297 | |||
| 298 | // Lists accept a non-list value as a list of one. |
||
| 299 | $coercedValue = $this->coerceValue($value, $itemType, $blameNode); |
||
| 300 | return new CoercedValue([$coercedValue->getValue()], $coercedValue->getErrors()); |
||
| 301 | } |
||
| 302 | |||
| 303 | if ($type instanceof InputObjectType) { |
||
| 304 | $errors = []; |
||
| 305 | $coercedValues = []; |
||
| 306 | $fields = $type->getFields(); |
||
| 307 | |||
| 308 | // Ensure every defined field is valid. |
||
| 309 | foreach ($fields as $field) { |
||
| 310 | if (!array_key_exists($field->getName(), $value)) { |
||
| 311 | if (!empty($field->getDefaultValue())) { |
||
| 312 | $coercedValue[$field->getName()] = $field->getDefaultValue(); |
||
| 313 | } elseif ($type instanceof NonNullType) { |
||
| 314 | $errors[] = new GraphQLException( |
||
| 315 | sprintf( |
||
| 316 | "Field %s of required type %s was not provided", |
||
| 317 | implode(",", array_merge($path, [$field->getName()])), |
||
| 318 | $type->getName() |
||
| 319 | ) |
||
| 320 | ); |
||
| 321 | } |
||
| 322 | } else { |
||
| 323 | $fieldValue = $value[$field->getName()]; |
||
| 324 | $coercedValue = $this->coerceValue( |
||
| 325 | $fieldValue, |
||
| 326 | $field->getType(), |
||
| 327 | $blameNode, |
||
| 328 | [$path, $field->getName()] // new path |
||
| 329 | ); |
||
| 330 | |||
| 331 | if ($coercedValue->hasErrors()) { |
||
| 332 | $errors = array_merge($errors, $coercedValue->getErrors()); |
||
| 333 | } elseif (empty($errors)) { |
||
| 334 | $coercedValues[$field->getName()] = $coercedValue->getValue(); |
||
| 335 | } |
||
| 336 | } |
||
| 337 | } |
||
| 338 | |||
| 339 | // Ensure every provided field is defined. |
||
| 340 | foreach ($value as $fieldName => $fieldValue) { |
||
| 341 | if ($fields[$fieldName] === null) { |
||
| 342 | $suggestion = suggestionList($fieldName, array_keys($fields)); |
||
| 343 | $errors[] = new GraphQLException( |
||
| 344 | sprintf('Field "%s" is not defined by type %s', $fieldName, $type->getName()) |
||
| 345 | ); |
||
| 346 | } |
||
| 347 | } |
||
| 348 | |||
| 349 | return new CoercedValue($coercedValues, $errors); |
||
| 350 | } |
||
| 351 | |||
| 352 | throw new GraphQLException('Unexpected type.'); |
||
| 353 | } |
||
| 426 |
Loading history...
