Digia\GraphQL\Language\AST\Visitor\AcceptVisitorTrait

Complexity

Total Complexity

15

Size/Duplication

Total Lines	199
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	addOneToPath()	0	3	1
D	accept()	0	37	9
A	visitNodes()	0	17	3
A	visitNode()	0	9	1
A	removeOneFromPath()	0	3	1

<?php

namespace Digia\GraphQL\Language\AST\Visitor;

use Digia\GraphQL\Language\AST\Node\NodeInterface;
use Digia\GraphQL\Util\SerializationInterface;

trait AcceptVisitorTrait
{

    /**
     * @var VisitorInterface
     */
    protected $visitor;

    /**
     * @var array
     */
    protected $path;

    /**
     * @var NodeInterface|null
     */
    protected $newNode;

    /**
     * @param VisitorInterface $visitor
     * @param string|null $key
     * @param array $path
     * @return NodeInterface|SerializationInterface|null
     */
    public function accept(VisitorInterface $visitor, ?string $key = null, array $path = []): ?NodeInterface
    {
        // TODO: Benchmark
        $this->newNode = clone $this;

It seems like clone $this of type Digia\GraphQL\Language\AST\Visitor\AcceptVisitorTrait is incompatible with the declared type null|Digia\GraphQL\Language\AST\Node\NodeInterface of property $newNode.

        $this->visitor = $visitor;
        $this->path = $path;

        if (null === ($this->newNode = $visitor->enterNode($this->newNode, $key, $this->path))) {

$this->newNode of type Digia\GraphQL\Language\AST\Visitor\AcceptVisitorTrait is incompatible with the type Digia\GraphQL\Language\AST\Node\NodeInterface expected by parameter $node of Digia\GraphQL\Language\AST\Visitor\VisitorInterface::enterNode().

            return null;
        }

        foreach (self::$kindToNodesToVisitMap[$this->kind] as $name) {

The property kind does not exist on Digia\GraphQL\Language\AST\Visitor\AcceptVisitorTrait. Did you maybe forget to declare it?

            /** @var NodeInterface|NodeInterface[] $nodeOrNodes */
            $nodeOrNodes = $this->{$name};

            if (null === $nodeOrNodes || empty($nodeOrNodes)) {
                continue;
            }

            $newNodeOrNodes = \is_array($nodeOrNodes)
                ? $this->visitNodes($nodeOrNodes, $name)
                : $this->visitNode($nodeOrNodes, $name);

            if (null === $newNodeOrNodes || empty($newNodeOrNodes)) {
                continue;
            }

            $setter = 'set' . ucfirst($name);
            $this->newNode->{$setter}($newNodeOrNodes);
        }

        if (null === ($this->newNode = $visitor->leaveNode($this->newNode, $key, $this->path))) {
            return null;
        }

        return $this->newNode;
    }

    /**
     * @param NodeInterface[] $nodes
     * @param string $key
     * @return NodeInterface[]
     */
    protected function visitNodes(array $nodes, string $key): array
    {
        $this->addOneToPath($key);

        $index = 0;
        $newNodes = [];

        foreach ($nodes as $node) {
            if (null !== ($newNode = $this->visitNode($node, $index))) {
                $newNodes[$index] = $newNode;
                $index++;
            }
        }

        $this->removeOneFromPath();

        return $newNodes;
    }

    /**
     * @param NodeInterface|AcceptVisitorTrait $node
     * @param string $key
     * @return NodeInterface|null
     */
    protected function visitNode(NodeInterface $node, string $key): ?NodeInterface
    {
        $this->addOneToPath($key);

        $newNode = $node->accept($this->visitor, $key, $this->path);

The method accept() does not exist on Digia\GraphQL\Language\AST\Node\NodeInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Digia\GraphQL\Language\AST\Node\DefinitionNodeInterface or Digia\GraphQL\Language\AST\Node\TypeExtensionNodeInterface or Digia\GraphQL\Language\AST\Node\ValueNodeInterface or Digia\GraphQL\Language\AST\Node\SelectionNodeInterface or Digia\GraphQL\Language\AST\Node\TypeNodeInterface or Digia\GraphQL\Language\AST\Node\TypeSystemDefinitionNodeInterface or Digia\GraphQL\Language\AST\Node\TypeDefinitionNodeInterface or Digia\GraphQL\Language\AST\Node\ExecutableDefinitionNodeInterface. Are you sure you never get one of those?

        $this->removeOneFromPath();

        return $newNode;
    }

    /**
     * Appends a key to the path.
     * @param string $key
     */
    protected function addOneToPath(string $key)
    {
        $this->path[] = $key;
    }

    /**
     * Removes the last item from the path.
     */
    protected function removeOneFromPath()
    {
        $this->path = \array_slice($this->path, 0, count($this->path) - 1);
    }

    /**
     * @var array
     */
    protected static $kindToNodesToVisitMap = [
        'Name' => [],

        'Document' => ['definitions'],
        'OperationDefinition' => [
            'name',
            'variableDefinitions',
            'directives',
            'selectionSet',
        ],
        'VariableDefinition' => ['variable', 'type', 'defaultValue'],
        'Variable' => ['name'],
        'SelectionSet' => ['selections'],
        'Field' => ['alias', 'name', 'arguments', 'directives', 'selectionSet'],
        'Argument' => ['name', 'value'],

        'FragmentSpread' => ['name', 'directives'],
        'InlineFragment' => ['typeCondition', 'directives', 'selectionSet'],
        'FragmentDefinition' => [
            'name',
            // Note: fragment variable definitions are experimental and may be changed or removed in the future.
            'variableDefinitions',
            'typeCondition',
            'directives',
            'selectionSet',
        ],

        'IntValue' => [],
        'FloatValue' => [],
        'StringValue' => [],
        'BooleanValue' => [],
        'NullValue' => [],
        'EnumValue' => [],
        'ListValue' => ['values'],
        'ObjectValue' => ['fields'],
        'ObjectField' => ['name', 'value'],

        'Directive' => ['name', 'arguments'],

        'NamedType' => ['name'],
        'ListType' => ['type'],
        'NonNullType' => ['type'],

        'SchemaDefinition' => ['directives', 'operationTypes'],
        'OperationTypeDefinition' => ['type'],

        'ScalarTypeDefinition' => ['description', 'name', 'directives'],
        'ObjectTypeDefinition' => [
            'description',
            'name',
            'interfaces',
            'directives',
            'fields',
        ],
        'FieldDefinition' => ['description', 'name', 'arguments', 'type', 'directives'],
        'InputValueDefinition' => [
            'description',
            'name',
            'type',
            'defaultValue',
            'directives',
        ],
        'InterfaceTypeDefinition' => ['description', 'name', 'directives', 'fields'],
        'UnionTypeDefinition' => ['description', 'name', 'directives', 'types'],
        'EnumTypeDefinition' => ['description', 'name', 'directives', 'values'],
        'EnumValueDefinition' => ['description', 'name', 'directives'],
        'InputObjectTypeDefinition' => ['description', 'name', 'directives', 'fields'],

        'ScalarTypeExtension' => ['name', 'directives'],
        'ObjectTypeExtension' => ['name', 'interfaces', 'directives', 'fields'],
        'InterfaceTypeExtension' => ['name', 'directives', 'fields'],
        'UnionTypeExtension' => ['name', 'directives', 'types'],
        'EnumTypeExtension' => ['name', 'directives', 'values'],
        'InputObjectTypeExtension' => ['name', 'directives', 'fields'],

        'DirectiveDefinition' => ['description', 'name', 'arguments', 'locations'],
    ];
}