descriptionLines() - Code Metrics - Inspection of "WIP: Schema printer" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#209)

by Christoffer

created 2018-04-15 10:40 UTC

descriptionLines() A

↳ Parent: Project

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	11
nc	3
nop	2
dl	0
loc	21
rs	9.0534
c	0
b	0
f	0

<?php

namespace Digia\GraphQL\Schema;

/**
 * @param string $description
 * @param int    $maxLength
 * @return array
 */
function descriptionLines(string $description, int $maxLength): array
{
    $lines         = [];
    $rawLines      = \explode("\n", $description);
    $rawLinesCount = \count($rawLines);

    for ($i = 0; $i < $rawLinesCount; $i++) {
        if ('' === $rawLines[$i]) {
            $lines[] = $rawLines[$i];
            continue;
        }

        // For > 120 character long lines, cut at space boundaries into sublines
        // of ~80 chars.
        $subLines = breakLine($rawLines[$i], $maxLength);
        for ($j = 0; $j < \count($subLines); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $lines[] = $subLines[$j];
        }
    }

    return $lines;
}

/**
 * @param string $line
 * @param int    $maxLength
 * @return array
 */
function breakLine(string $line, int $maxLength): array
{
    if (\strlen($line) < ($maxLength + 5)) {
        return [$line];
    }

    $pos        = $maxLength - 40;
    $parts      = \preg_split("/((?: |^).{15,{$pos}}(?= |$))/", $line);
    $partsCount = \count($parts);
    $partsCount = \count(/** @scrutinizer ignore-type */ $parts);

    if ($partsCount < 4) {
        return [$line];
    }

    $subLines = [$parts[0] . $parts[1] . $parts[2]];

    for ($i = 3; $i < $partsCount; $i++) {
        $subLines[] = \array_slice($parts[$i], 1) . $parts[$i + 1];
        $subLines[] = /** @scrutinizer ignore-type */ \array_slice($parts[$i], 1) . $parts[$i + 1];
    }

    return $subLines;
}

/**
 * @param string $line
 * @return string
 */
function escapeQuote(string $line): string
{
    return \preg_replace('/"""/g', '\\"""', $line);
}


digiaonline / graphql-php

Pull Request — master (#209)

descriptionLines() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like