TypeTrait::getNullableType() - Code Metrics - Inspection of "Add GraphQL contracts support" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#351)

by Kirill

created 2019-10-29 04:22 UTC

TypeTrait::getNullableType() A

↳ Parent: TypeTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Digia\GraphQL\Type\Definition;

use GraphQL\Contracts\TypeSystem\Common\TypeAwareInterface;
use GraphQL\Contracts\TypeSystem\Type\TypeInterface;

/**
 * @mixin TypeAwareInterface
 */
trait TypeTrait
{
    /**
     * @var TypeInterface|null
     */
    protected $type;

    /**
     * @return TypeInterface
     */
    public function getType(): TypeInterface
    {
        return $this->type;

    }

    /**
     * @internal This is a method for obtaining a type that implements compatibility with an current implementation
     * @return TypeInterface|null
     */
    public function getNullableType(): ?TypeInterface
    {
        return $this->type;
    }
}


1			<?php
2
3			namespace Digia\GraphQL\Type\Definition;
4
5			use GraphQL\Contracts\TypeSystem\Common\TypeAwareInterface;
6			use GraphQL\Contracts\TypeSystem\Type\TypeInterface;
7
8			/**
9			* @mixin TypeAwareInterface
10			*/
11			trait TypeTrait
12			{
13			/**
14			* @var TypeInterface\|null
15			*/
16			protected $type;
17
18			/**
19			* @return TypeInterface
20			*/
21			public function getType(): TypeInterface
22			{
23			return $this->type;
			0 ignored issues – show Bug Best Practice introduced 2019-10-29 04:02 UTC by Report Bug Copy Issue Report The expression `return $this->type` could return the type `null` which is incompatible with the type-hinted return `GraphQL\Contracts\TypeSystem\Type\TypeInterface`. Consider adding an additional type-check to rule them out. Loading history...
24			}
25
26			/**
27			* @internal This is a method for obtaining a type that implements compatibility with an current implementation
28			* @return TypeInterface\|null
29			*/
30			public function getNullableType(): ?TypeInterface
31			{
32			return $this->type;
33			}
34			}
35

digiaonline / graphql-php

Pull Request — master (#351)

TypeTrait::getNullableType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like