Digia\GraphQL\Language\Node\DefaultValueTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getDefaultValueAsArray()	0	3	2
A	hasDefaultValue()	0	3	1
A	getDefaultValue()	0	3	1

<?php

namespace Digia\GraphQL\Language\Node;

use Digia\GraphQL\Util\SerializationInterface;

trait DefaultValueTrait
{

    /**
     * @var ValueNodeInterface|SerializationInterface|null
     */
    protected $defaultValue;

    /**
     * @return bool
     */
    public function hasDefaultValue(): bool
    {
        return null !== $this->defaultValue;
    }

    /**
     * @return ValueNodeInterface|SerializationInterface|null
     */
    public function getDefaultValue(): ?ValueNodeInterface
    {
        return $this->defaultValue;

The expression return $this->defaultValue could return the type Digia\GraphQL\Util\SerializationInterface which is incompatible with the type-hinted return null|Digia\GraphQL\Language\Node\ValueNodeInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return array
     */
    public function getDefaultValueAsArray(): ?array
    {
        return null !== $this->defaultValue ? $this->defaultValue->toArray() : null;

The method toArray() does not exist on Digia\GraphQL\Language\Node\ValueNodeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Digia\GraphQL\Language\Node\ValueNodeInterface.

    }
}