NameHelper::assertInvalid() - Code Metrics - Inspection of "Refactor helper functions to use the container" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#158)

by Christoffer

created 2018-03-29 13:49 UTC

NameHelper::assertInvalid() A

↳ Parent: NameHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Digia\GraphQL\Util;

use Digia\GraphQL\Error\InvariantException;
use Digia\GraphQL\Error\ValidationException;
use Digia\GraphQL\Language\Node\NodeInterface;

class NameHelper
{
    /**
     * Upholds the spec rules about naming.
     *
     * @param string $name
     * @return string
     * @throws InvariantException
     * @throws ValidationException
     */
    function assertInvalid(string $name): string

    {
        $error = $this->isValidError($name);

        if ($error) {
            throw $error;
        }

        return $name;
    }

    /**
     * Returns an Error if a name is invalid.
     *
     * @param string     $name
     * @param mixed|null $node
     * @return ValidationException
     * @throws InvariantException
     */
    function isValidError(string $name, $node = null): ?ValidationException

    {
        invariant(\is_string($name), 'Expected string');

        if (\strlen($name) > 1 && $name{0} === '_' && $name{1} === '_') {
            return new ValidationException(
                sprintf('Name "%s" must not begin with "__", which is reserved by GraphQL introspection.', $name),
                $node instanceof NodeInterface ? [$node] : null
            );
        }

        if (preg_match("/^[_a-zA-Z][_a-zA-Z0-9]*$/", $name) === 0) {
            return new ValidationException(
                sprintf('Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "%s" does not.', $name),
                $node instanceof NodeInterface ? [$node] : null
            );
        }

        return null;
    }
}


1			<?php
2
3			namespace Digia\GraphQL\Util;
4
5			use Digia\GraphQL\Error\InvariantException;
6			use Digia\GraphQL\Error\ValidationException;
7			use Digia\GraphQL\Language\Node\NodeInterface;
8
9			class NameHelper
10			{
11			/**
12			* Upholds the spec rules about naming.
13			*
14			* @param string $name
15			* @return string
16			* @throws InvariantException
17			* @throws ValidationException
18			*/
19			function assertInvalid(string $name): string
			0 ignored issues – show Best Practice introduced 2018-03-16 21:45 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
20			{
21			$error = $this->isValidError($name);
22
23			if ($error) {
24			throw $error;
25			}
26
27			return $name;
28			}
29
30			/**
31			* Returns an Error if a name is invalid.
32			*
33			* @param string $name
34			* @param mixed\|null $node
35			* @return ValidationException
36			* @throws InvariantException
37			*/
38			function isValidError(string $name, $node = null): ?ValidationException
			0 ignored issues – show Best Practice introduced 2018-03-16 21:45 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
39			{
40			invariant(\is_string($name), 'Expected string');
41
42			if (\strlen($name) > 1 && $name{0} === '_' && $name{1} === '_') {
43			return new ValidationException(
44			sprintf('Name "%s" must not begin with "__", which is reserved by GraphQL introspection.', $name),
45			$node instanceof NodeInterface ? [$node] : null
46			);
47			}
48
49			if (preg_match("/^[_a-zA-Z][_a-zA-Z0-9]*$/", $name) === 0) {
50			return new ValidationException(
51			sprintf('Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "%s" does not.', $name),
52			$node instanceof NodeInterface ? [$node] : null
53			);
54			}
55
56			return null;
57			}
58			}
59

digiaonline / graphql-php

Pull Request — master (#158)

NameHelper::assertInvalid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like