DirectivesRule::evaluate() - Code Metrics - Inspection of "WIP: Schema extension" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#159)

by Christoffer

created 2018-03-29 20:10 UTC

DirectivesRule::evaluate() B

↳ Parent: DirectivesRule

Complexity

Conditions	7
Paths	6

Size

Total Lines	61
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	61
rs	7.399
c	0
b	0
f	0
cc	7
eloc	33
nc	6
nop	0

How to fix Long Method

<?php

namespace Digia\GraphQL\SchemaValidation\Rule;

use Digia\GraphQL\Error\InvariantException;
use Digia\GraphQL\Error\SchemaValidationException;
use Digia\GraphQL\Language\Node\DirectiveNode;
use Digia\GraphQL\Language\Node\NodeAwareInterface;
use Digia\GraphQL\Type\Definition\Directive;
use Digia\GraphQL\Type\Definition\DirectiveInterface;
use function Digia\GraphQL\Type\isInputType;
use function Digia\GraphQL\Util\isValidNameError;

class DirectivesRule extends AbstractRule
{
    /**
     * @inheritdoc
     */
    public function evaluate(): void
    {
        $directives = $this->context->getSchema()->getDirectives();

        foreach ($directives as $directive) {
            if (!($directive instanceof DirectiveInterface)) {
                $this->context->reportError(
                    new SchemaValidationException(
                        \sprintf(
                            'Expected directive but got: %s.',
                            $directive instanceof NodeAwareInterface ? $directive->getAstNode() : $directive
                            /** @scrutinizer ignore-type */ $directive instanceof NodeAwareInterface ? $directive->getAstNode() : $directive
                        )
                    )
                );

                return;
            }

            // Ensure they are named correctly.
            $this->validateName($directive);

            // TODO: Ensure proper locations.

            // Ensure the arguments are valid.
            $argumentNames = [];

            foreach ($directive->getArguments() as $argument) {
                $argumentName = $argument->getName();

                // Ensure they are named correctly.
                $this->validateName($argument);

                // Ensure they are unique per directive.
                if (isset($argumentNames[$argumentName])) {
                    $this->context->reportError(
                        new SchemaValidationException(
                            \sprintf(
                                'Argument @%s(%s:) can only be defined once.',
                                $directive->getName(),
                                $argumentName
                            ),
                            $this->getAllDirectiveArgumentNodes($directive, $argumentName)
                        )
                    );

                    continue;
                }

                $argumentNames[$argumentName] = true;

                // Ensure the type is an input type.
                if (!isInputType($argument->getType())) {
                    $this->context->reportError(
                        new SchemaValidationException(
                            \sprintf(
                                'The type of @%s(%s:) must be Input Type but got: %s.',
                                $directive->getName(),
                                $argumentName,
                                (string)$argument->getType()
                            ),
                            $this->getAllDirectiveArgumentNodes($directive, $argumentName)
                        )
                    );
                }
            }
        }
    }

    /**
     * @param Directive $directive
     * @param string    $argumentName
     * @return array
     */
    protected function getAllDirectiveArgumentNodes(Directive $directive, string $argumentName)
    {
        $nodes = [];

        /** @var DirectiveNode $directiveNode */
        $directiveNode = $directive->getAstNode();

        if (null !== $directiveNode) {
            foreach ($directiveNode->getArguments() as $node) {
                if ($node->getNameValue() === $argumentName) {
                    $nodes[] = $node;
                }
            }
        }

        return $nodes;
    }

    /**
     * @param mixed $node
     * @throws InvariantException
     */
    protected function validateName($node): void
    {
        // Ensure names are valid, however introspection types opt out.
        $error = isValidNameError($node->getName(), $node);

        if (null !== $error) {
            $this->context->reportError($error);
        }
    }
}


digiaonline / graphql-php

Pull Request — master (#159)

DirectivesRule::evaluate() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like