BuildInfo::getDocument() - Code Metrics - Inspection of "Refactor definition builder usage" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#173)

by Christoffer

created 2018-04-03 06:42 UTC

BuildInfo::getDocument() A

↳ Parent: BuildInfo

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	0

<?php

namespace Digia\GraphQL\Schema\Building;

use Digia\GraphQL\Language\Node\DirectiveDefinitionNode;
use Digia\GraphQL\Language\Node\DocumentNode;
use Digia\GraphQL\Language\Node\NodeInterface;
use Digia\GraphQL\Language\Node\OperationTypeDefinitionNode;
use Digia\GraphQL\Language\Node\SchemaDefinitionNode;
use Digia\GraphQL\Language\Node\TypeNodeInterface;
use Digia\GraphQL\Type\Definition\TypeInterface;

class BuildInfo
{
    /**
     * @var DocumentNode
     */
    protected $document;

    /**
     * @var TypeInterface[]
     */
    protected $typeDefinitionMap;

    /**
     * @var DirectiveDefinitionNode[]
     */
    protected $directiveDefinitions;

    /**
     * @var OperationTypeDefinitionNode[]
     */
    protected $operationTypeDefinitions;

    /**
     * @var SchemaDefinitionNode|null
     */
    protected $schemaDefinition;

    /**
     * BuildingInfo constructor.
     * @param DocumentNode                  $document
     * @param TypeInterface[]               $typeDefinitionMap
     * @param DirectiveDefinitionNode[]     $directiveDefinitions
     * @param OperationTypeDefinitionNode[] $operationTypeDefinitions
     * @param SchemaDefinitionNode|null     $schemaDefinition
     */
    public function __construct(
        DocumentNode $document,
        array $typeDefinitionMap,
        array $directiveDefinitions,
        array $operationTypeDefinitions,
        ?SchemaDefinitionNode $schemaDefinition = null
    ) {
        $this->document                 = $document;
        $this->typeDefinitionMap        = $typeDefinitionMap;
        $this->directiveDefinitions     = $directiveDefinitions;
        $this->operationTypeDefinitions = $operationTypeDefinitions;
        $this->schemaDefinition         = $schemaDefinition;
    }

    /**
     * @param string $typeName
     * @return TypeInterface|null
     */
    public function getTypeDefinition(string $typeName): ?TypeInterface
    {
        return $this->typeDefinitionMap[$typeName] ?? null;
    }

    /**
     * @param string $operation
     * @return TypeNodeInterface|null
     */
    public function getOperationTypeDefinition(string $operation): ?NodeInterface
    {
        return $this->operationTypeDefinitions[$operation] ?? $this->typeDefinitionMap[\ucfirst($operation)] ?? null;

    }

    /**
     * @return DocumentNode
     */
    public function getDocument(): DocumentNode
    {
        return $this->document;
    }

    /**
     * @return SchemaDefinitionNode|null
     */
    public function getSchemaDefinition(): ?SchemaDefinitionNode
    {
        return $this->schemaDefinition;
    }

    /**
     * @return TypeInterface[]
     */
    public function getTypeDefinitionMap(): array
    {
        return $this->typeDefinitionMap;
    }

    /**
     * @return DirectiveDefinitionNode[]
     */
    public function getDirectiveDefinitions(): array
    {
        return $this->directiveDefinitions;
    }
}


1			<?php
2
3			namespace Digia\GraphQL\Schema\Building;
4
5			use Digia\GraphQL\Language\Node\DirectiveDefinitionNode;
6			use Digia\GraphQL\Language\Node\DocumentNode;
7			use Digia\GraphQL\Language\Node\NodeInterface;
8			use Digia\GraphQL\Language\Node\OperationTypeDefinitionNode;
9			use Digia\GraphQL\Language\Node\SchemaDefinitionNode;
10			use Digia\GraphQL\Language\Node\TypeNodeInterface;
11			use Digia\GraphQL\Type\Definition\TypeInterface;
12
13			class BuildInfo
14			{
15			/**
16			* @var DocumentNode
17			*/
18			protected $document;
19
20			/**
21			* @var TypeInterface[]
22			*/
23			protected $typeDefinitionMap;
24
25			/**
26			* @var DirectiveDefinitionNode[]
27			*/
28			protected $directiveDefinitions;
29
30			/**
31			* @var OperationTypeDefinitionNode[]
32			*/
33			protected $operationTypeDefinitions;
34
35			/**
36			* @var SchemaDefinitionNode\|null
37			*/
38			protected $schemaDefinition;
39
40			/**
41			* BuildingInfo constructor.
42			* @param DocumentNode $document
43			* @param TypeInterface[] $typeDefinitionMap
44			* @param DirectiveDefinitionNode[] $directiveDefinitions
45			* @param OperationTypeDefinitionNode[] $operationTypeDefinitions
46			* @param SchemaDefinitionNode\|null $schemaDefinition
47			*/
48			public function __construct(
49			DocumentNode $document,
50			array $typeDefinitionMap,
51			array $directiveDefinitions,
52			array $operationTypeDefinitions,
53			?SchemaDefinitionNode $schemaDefinition = null
54			) {
55			$this->document = $document;
56			$this->typeDefinitionMap = $typeDefinitionMap;
57			$this->directiveDefinitions = $directiveDefinitions;
58			$this->operationTypeDefinitions = $operationTypeDefinitions;
59			$this->schemaDefinition = $schemaDefinition;
60			}
61
62			/**
63			* @param string $typeName
64			* @return TypeInterface\|null
65			*/
66			public function getTypeDefinition(string $typeName): ?TypeInterface
67			{
68			return $this->typeDefinitionMap[$typeName] ?? null;
69			}
70
71			/**
72			* @param string $operation
73			* @return TypeNodeInterface\|null
74			*/
75			public function getOperationTypeDefinition(string $operation): ?NodeInterface
76			{
77			return $this->operationTypeDefinitions[$operation] ?? $this->typeDefinitionMap[\ucfirst($operation)] ?? null;
			0 ignored issues – show Bug Best Practice introduced 2018-04-02 12:31 UTC by Report Bug Copy Issue Report The expression `return $this->operationT...st($operation)] ?? null` could return the type `Digia\GraphQL\Type\Definition\TypeInterface` which is incompatible with the type-hinted return `null\|Digia\GraphQL\Language\Node\NodeInterface`. Consider adding an additional type-check to rule them out. Loading history...
78			}
79
80			/**
81			* @return DocumentNode
82			*/
83			public function getDocument(): DocumentNode
84			{
85			return $this->document;
86			}
87
88			/**
89			* @return SchemaDefinitionNode\|null
90			*/
91			public function getSchemaDefinition(): ?SchemaDefinitionNode
92			{
93			return $this->schemaDefinition;
94			}
95
96			/**
97			* @return TypeInterface[]
98			*/
99			public function getTypeDefinitionMap(): array
100			{
101			return $this->typeDefinitionMap;
102			}
103
104			/**
105			* @return DirectiveDefinitionNode[]
106			*/
107			public function getDirectiveDefinitions(): array
108			{
109			return $this->directiveDefinitions;
110			}
111			}
112

digiaonline / graphql-php

Pull Request — master (#173)

BuildInfo::getDocument() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like