Digia\GraphQL\Language\ASTBuilder\TypeReferenceASTBuilder::parseTypeReference()

Complexity

Conditions	3
Paths	4

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function parseTypeReference(LexerInterface $lexer): array
    {
        $start = $lexer->getToken();

        if ($this->skip($lexer, TokenKindEnum::BRACKET_L)) {
            $type = $this->parseTypeReference($lexer);

            $this->expect($lexer, TokenKindEnum::BRACKET_R);

            $type = [
                'kind' => NodeKindEnum::LIST_TYPE,
                'type' => $type,
                'loc'  => $this->buildLocation($lexer, $start),
            ];
        } else {
            $type = $this->buildAST(ASTKindEnum::NAMED_TYPE, $lexer);
        }

        if ($this->skip($lexer, TokenKindEnum::BANG)) {
            return [
                'kind' => NodeKindEnum::NON_NULL_TYPE,
                'type' => $type,
                'loc'  => $this->buildLocation($lexer, $start),
            ];
        }

        return $type;

The expression return $type could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }