Digia\GraphQL\Language\AST\Node\ValueLiteralTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getValue()	0	3	1
A	getValueAsArray()	0	3	2
A	setValue()	0	4	1

<?php

namespace Digia\GraphQL\Language\AST\Node;

use Digia\GraphQL\Util\SerializationInterface;

trait ValueLiteralTrait
{

    /**
     * @var ValueNodeInterface|SerializationInterface|null
     */
    protected $value;

    /**
     * @return ValueNodeInterface|null
     */
    public function getValue(): ?ValueNodeInterface
    {
        return $this->value;

The expression return $this->value could return the type Digia\GraphQL\Util\SerializationInterface which is incompatible with the type-hinted return null|Digia\GraphQL\Language\AST\Node\ValueNodeInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return array
     */
    public function getValueAsArray(): array
    {
        return null !== $this->value ? $this->value->toArray() : null;

The expression return null !== $this->value ? $this->value->toArray() : null could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

The method toArray() does not exist on Digia\GraphQL\Language\AST\Node\ValueNodeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Digia\GraphQL\Language\AST\Node\ValueNodeInterface.

    }

    /**
     * @param ValueNodeInterface|null $value
     * @return $this
     */
    public function setValue(?ValueNodeInterface $value)
    {
        $this->value = $value;
        return $this;
    }
}