FieldsTrait::buildFieldMap() - Code Metrics - Inspection of "Introduce subscribe method to Field (#203)" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ffa870...12eb4f )

by Christoffer

created 2018-04-12 20:32 UTC

FieldsTrait::buildFieldMap() A

↳ Parent: FieldsTrait

Complexity

Conditions	4
Paths	3

Size

Total Lines	54
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	35
nc	3
nop	1
dl	0
loc	54
rs	9.0306
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Digia\GraphQL\Type\Definition;

use Digia\GraphQL\Error\InvariantException;
use function Digia\GraphQL\Type\isAssocArray;
use function Digia\GraphQL\Type\resolveThunk;
use function Digia\GraphQL\Util\invariant;
use function Digia\GraphQL\Util\toString;

trait FieldsTrait
{
    /**
     * Fields can be defined either as an array or as a thunk.
     * Using thunks allows for cross-referencing of fields.
     *
     * @var array|callable
     */
    protected $fieldsOrThunk;

    /**
     * A key-value map over field names and their corresponding field instances.
     *
     * @var Field[]
     */
    protected $fieldMap;

    /**
     * @return null|string
     */
    abstract public function getName(): ?string;

    /**
     * @param string $fieldName
     * @return Field|null
     * @throws InvariantException
     */
    public function getField(string $fieldName): ?Field
    {
        return $this->getFields()[$fieldName] ?? null;
    }

    /**
     * @return Field[]
     * @throws InvariantException
     */
    public function getFields(): array
    {
        // Fields are built lazily to avoid concurrency issues.
        if (!isset($this->fieldMap)) {
            $this->fieldMap = $this->buildFieldMap($this->fieldsOrThunk);
        }

        return $this->fieldMap;
    }

    /**
     * @param array|callable $fieldsOrThunk
     * @return array
     * @throws InvariantException
     */
    protected function buildFieldMap($fieldsOrThunk): array
    {
        $fields = resolveThunk($fieldsOrThunk);

        invariant(
            isAssocArray($fields),
            \sprintf(
                '%s fields must be an associative array with field names as key or a callable which returns such an array.',
                $this->getName()
            )
        );

        $fieldMap = [];

        foreach ($fields as $fieldName => $fieldConfig) {
            invariant(
                \is_array($fieldConfig),
                \sprintf('%s.%s field config must be an array', $this->getName(), $fieldName)
            );

            invariant(
                !isset($fieldConfig['isDeprecated']),
                \sprintf(
                    '%s.%s should provide "deprecationReason" instead of "isDeprecated".',
                    $this->getName(),
                    $fieldName
                )
            );

            if (isset($fieldConfig['resolve'])) {
                invariant(
                    null === $fieldConfig['resolve'] || \is_callable($fieldConfig['resolve']),
                    \sprintf(
                        '%s.%s field resolver must be a function if provided, but got: %s',
                        $this->getName(),
                        $fieldName,
                        toString($fieldConfig['resolve'])
                    )
                );
            }

            $fieldMap[$fieldName] = new Field(
                $fieldName,
                $fieldConfig['description'] ?? null,
                $fieldConfig['type'] ?? null,
                $fieldConfig['args'] ?? [],
                $fieldConfig['resolve'] ?? null,
                $fieldConfig['subscribe'] ?? null,
                $fieldConfig['deprecationReason'] ?? null,
                $fieldConfig['astNode'] ?? null
            );
        }

        return $fieldMap;
    }
}


1			<?php
2
3			namespace Digia\GraphQL\Type\Definition;
4
5			use Digia\GraphQL\Error\InvariantException;
6			use function Digia\GraphQL\Type\isAssocArray;
7			use function Digia\GraphQL\Type\resolveThunk;
8			use function Digia\GraphQL\Util\invariant;
9			use function Digia\GraphQL\Util\toString;
10
11			trait FieldsTrait
12			{
13			/**
14			* Fields can be defined either as an array or as a thunk.
15			* Using thunks allows for cross-referencing of fields.
16			*
17			* @var array\|callable
18			*/
19			protected $fieldsOrThunk;
20
21			/**
22			* A key-value map over field names and their corresponding field instances.
23			*
24			* @var Field[]
25			*/
26			protected $fieldMap;
27
28			/**
29			* @return null\|string
30			*/
31			abstract public function getName(): ?string;
32
33			/**
34			* @param string $fieldName
35			* @return Field\|null
36			* @throws InvariantException
37			*/
38			public function getField(string $fieldName): ?Field
39			{
40			return $this->getFields()[$fieldName] ?? null;
41			}
42
43			/**
44			* @return Field[]
45			* @throws InvariantException
46			*/
47			public function getFields(): array
48			{
49			// Fields are built lazily to avoid concurrency issues.
50			if (!isset($this->fieldMap)) {
51			$this->fieldMap = $this->buildFieldMap($this->fieldsOrThunk);
52			}
53
54			return $this->fieldMap;
55			}
56
57			/**
58			* @param array\|callable $fieldsOrThunk
59			* @return array
60			* @throws InvariantException
61			*/
62			protected function buildFieldMap($fieldsOrThunk): array
63			{
64			$fields = resolveThunk($fieldsOrThunk);
65
66			invariant(
67			isAssocArray($fields),
68			\sprintf(
69			'%s fields must be an associative array with field names as key or a callable which returns such an array.',
70			$this->getName()
71			)
72			);
73
74			$fieldMap = [];
75
76			foreach ($fields as $fieldName => $fieldConfig) {
77			invariant(
78			\is_array($fieldConfig),
79			\sprintf('%s.%s field config must be an array', $this->getName(), $fieldName)
80			);
81
82			invariant(
83			!isset($fieldConfig['isDeprecated']),
84			\sprintf(
85			'%s.%s should provide "deprecationReason" instead of "isDeprecated".',
86			$this->getName(),
87			$fieldName
88			)
89			);
90
91			if (isset($fieldConfig['resolve'])) {
92			invariant(
93			null === $fieldConfig['resolve'] \|\| \is_callable($fieldConfig['resolve']),
94			\sprintf(
95			'%s.%s field resolver must be a function if provided, but got: %s',
96			$this->getName(),
97			$fieldName,
98			toString($fieldConfig['resolve'])
99			)
100			);
101			}
102
103			$fieldMap[$fieldName] = new Field(
104			$fieldName,
105			$fieldConfig['description'] ?? null,
106			$fieldConfig['type'] ?? null,
107			$fieldConfig['args'] ?? [],
108			$fieldConfig['resolve'] ?? null,
109			$fieldConfig['subscribe'] ?? null,
110			$fieldConfig['deprecationReason'] ?? null,
111			$fieldConfig['astNode'] ?? null
112			);
113			}
114
115			return $fieldMap;
116			}
117			}
118

digiaonline / graphql-php

Push — master ( ffa870...12eb4f )

FieldsTrait::buildFieldMap() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like