PairSet::has() - Code Metrics - Inspection of "WIP: OverlappingFieldsCanBeMerged validation rule" - digiaonline/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#69)

by Christoffer

created 2018-03-11 20:50 UTC

PairSet::has() A

↳ Parent: PairSet

Complexity

Conditions	4
Paths	6

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	6
nop	3
dl	0
loc	17
rs	9.2
c	0
b	0
f	0

<?php

namespace Digia\GraphQL\Validation\Conflict;

/**
 * A way to keep track of pairs of things when the ordering of the pair does
 * not matter. We do this by maintaining a sort of double adjacency sets.
 */
class PairSet
{
    /**
     * @var array
     */
    protected $data = [];

    /**
     * @param string $a
     * @param string $b
     * @param bool   $areMutuallyExclusive
     * @return bool
     */
    public function has(string $a, string $b, bool $areMutuallyExclusive): bool
    {
        $first = $this->data[$a] ?? null;
        $result = null !== $first && ($first[$b] ?? null);

        if (null === $result) {

            return false;
        }

        // areMutuallyExclusive being false is a superset of being true,
        // hence if we want to know if this PairSet "has" these two with no
        // exclusivity, we have to ensure it was added as such.
        if ($areMutuallyExclusive === false) {
            return $result === false;
        }

        return true;
    }

    /**
     * @param string $a
     * @param string $b
     * @param bool   $areMutuallyExclusive
     */
    public function add(string $a, string $b, bool $areMutuallyExclusive): void
    {
        $this->addToData($a, $b, $areMutuallyExclusive);
        $this->addToData($b, $a, $areMutuallyExclusive);
    }

    /**
     * @param string $a
     * @param string $b
     * @param bool   $areMutuallyExclusive
     */
    protected function addToData(string $a, string $b, bool $areMutuallyExclusive): void
    {
        $map = $this->data[$a] ?? null;

        if (null === $map) {
            $map = [];
            $this->data[$a] = $map;
        }

        $map[$b] = $areMutuallyExclusive;
    }
}


1			<?php
2
3			namespace Digia\GraphQL\Validation\Conflict;
4
5			/**
6			* A way to keep track of pairs of things when the ordering of the pair does
7			* not matter. We do this by maintaining a sort of double adjacency sets.
8			*/
9			class PairSet
10			{
11			/**
12			* @var array
13			*/
14			protected $data = [];
15
16			/**
17			* @param string $a
18			* @param string $b
19			* @param bool $areMutuallyExclusive
20			* @return bool
21			*/
22			public function has(string $a, string $b, bool $areMutuallyExclusive): bool
23			{
24			$first = $this->data[$a] ?? null;
25			$result = null !== $first && ($first[$b] ?? null);
26
27			if (null === $result) {
			0 ignored issues – show introduced 2018-03-10 21:23 UTC by Report Bug Copy Issue Report The condition `null === $result` is always `false`. Loading history...
28			return false;
29			}
30
31			// areMutuallyExclusive being false is a superset of being true,
32			// hence if we want to know if this PairSet "has" these two with no
33			// exclusivity, we have to ensure it was added as such.
34			if ($areMutuallyExclusive === false) {
35			return $result === false;
36			}
37
38			return true;
39			}
40
41			/**
42			* @param string $a
43			* @param string $b
44			* @param bool $areMutuallyExclusive
45			*/
46			public function add(string $a, string $b, bool $areMutuallyExclusive): void
47			{
48			$this->addToData($a, $b, $areMutuallyExclusive);
49			$this->addToData($b, $a, $areMutuallyExclusive);
50			}
51
52			/**
53			* @param string $a
54			* @param string $b
55			* @param bool $areMutuallyExclusive
56			*/
57			protected function addToData(string $a, string $b, bool $areMutuallyExclusive): void
58			{
59			$map = $this->data[$a] ?? null;
60
61			if (null === $map) {
62			$map = [];
63			$this->data[$a] = $map;
64			}
65
66			$map[$b] = $areMutuallyExclusive;
67			}
68			}
69

digiaonline / graphql-php

Pull Request — master (#69)

PairSet::has() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like