Digia\GraphQL\Validation\Rule\OverlappingFieldsCanBeMergedRule

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	enterNode()	0	16	3

<?php

namespace Digia\GraphQL\Validation\Rule;

use Digia\GraphQL\Error\ValidationException;
use Digia\GraphQL\Language\AST\Node\NodeInterface;
use Digia\GraphQL\Language\AST\Node\SelectionSetNode;
use Digia\GraphQL\Validation\Conflict\FindsConflictsTrait;
use function Digia\GraphQL\Validation\fieldsConflictMessage;

/**
 * Overlapping fields can be merged
 *
 * A selection set is only valid if all fields (including spreading any
 * fragments) either correspond to distinct response names or can be merged
 * without ambiguity.
 */
class OverlappingFieldsCanBeMergedRule extends AbstractRule
{
    use FindsConflictsTrait;

    /**
     * @inheritdoc
     */
    public function enterNode(NodeInterface $node): ?NodeInterface
    {
        if ($node instanceof SelectionSetNode) {
            $parentType = $this->validationContext->getParentType();

            foreach ($this->findConflictsWithinSelectionSet($node, $parentType) as $conflict) {

It seems like $parentType can also be of type Digia\GraphQL\Type\Definition\TypeInterface; however, parameter $parentType of Digia\GraphQL\Validation\Rule\OverlappingFieldsCanBeMergedRule::findConflictsWithinSelectionSet() does only seem to accept null|Digia\GraphQL\Type\Definition\NamedTypeInterface, maybe add an additional type check?

                $this->validationContext->reportError(
                    new ValidationException(
                        fieldsConflictMessage($conflict->getResponseName(), $conflict->getReason()),
                        $conflict->getAllFields()
                    )
                );
            }
        }

        return $node;
    }
}