Digia\GraphQL\Validation\Rule\UniqueVariableNamesRule::enterVariableDefinition()

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function enterVariableDefinition(VariableDefinitionNode $node): VisitorResult
    {
        $variable     = $node->getVariable();
        $variableName = $variable->getNameValue();

        if (isset($this->knownVariableNames[$variableName])) {
            $this->context->reportError(
                new ValidationException(
                    duplicateVariableMessage($variableName),

It seems like $variableName can also be of type null; however, parameter $variableName of Digia\GraphQL\Validation\duplicateVariableMessage() does only seem to accept string, maybe add an additional type check?

                    [$this->knownVariableNames[$variableName], $variable->getName()]
                )
            );
        } else {
            $this->knownVariableNames[$variableName] = $variable->getName();
        }

        return new VisitorResult($node);
    }