Conditions | 27 |
Paths | 20 |
Total Lines | 63 |
Code Lines | 43 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
81 | protected function getDirectiveLocationFromASTPath(NodeInterface $node): ?string |
||
82 | { |
||
83 | $appliedTo = $node->getAncestor(); |
||
84 | |||
85 | if ($appliedTo instanceof OperationDefinitionNode) { |
||
86 | switch ($appliedTo->getOperation()) { |
||
87 | case 'query': |
||
88 | return DirectiveLocationEnum::QUERY; |
||
89 | case 'mutation': |
||
90 | return DirectiveLocationEnum::MUTATION; |
||
91 | case 'subscription': |
||
92 | return DirectiveLocationEnum::SUBSCRIPTION; |
||
93 | default: |
||
94 | return null; |
||
95 | } |
||
96 | } |
||
97 | if ($appliedTo instanceof FieldNode) { |
||
98 | return DirectiveLocationEnum::FIELD; |
||
99 | } |
||
100 | if ($appliedTo instanceof FragmentSpreadNode) { |
||
101 | return DirectiveLocationEnum::FRAGMENT_SPREAD; |
||
102 | } |
||
103 | if ($appliedTo instanceof InlineFragmentNode) { |
||
104 | return DirectiveLocationEnum::INLINE_FRAGMENT; |
||
105 | } |
||
106 | if ($appliedTo instanceof FragmentDefinitionNode) { |
||
107 | return DirectiveLocationEnum::FRAGMENT_DEFINITION; |
||
108 | } |
||
109 | if ($appliedTo instanceof SchemaDefinitionNode || $appliedTo instanceof SchemaExtensionNode) { |
||
110 | return DirectiveLocationEnum::SCHEMA; |
||
111 | } |
||
112 | if ($appliedTo instanceof ScalarTypeDefinitionNode || $appliedTo instanceof ScalarTypeExtensionNode) { |
||
113 | return DirectiveLocationEnum::SCALAR; |
||
114 | } |
||
115 | if ($appliedTo instanceof ObjectTypeDefinitionNode || $appliedTo instanceof ObjectTypeExtensionNode) { |
||
116 | return DirectiveLocationEnum::OBJECT; |
||
117 | } |
||
118 | if ($appliedTo instanceof FieldDefinitionNode) { |
||
119 | return DirectiveLocationEnum::FIELD_DEFINITION; |
||
120 | } |
||
121 | if ($appliedTo instanceof InterfaceTypeDefinitionNode || $appliedTo instanceof InterfaceTypeExtensionNode) { |
||
122 | return DirectiveLocationEnum::INTERFACE; |
||
123 | } |
||
124 | if ($appliedTo instanceof UnionTypeDefinitionNode || $appliedTo instanceof UnionTypeExtensionNode) { |
||
125 | return DirectiveLocationEnum::UNION; |
||
126 | } |
||
127 | if ($appliedTo instanceof EnumTypeDefinitionNode || $appliedTo instanceof EnumTypeExtensionNode) { |
||
128 | return DirectiveLocationEnum::ENUM; |
||
129 | } |
||
130 | if ($appliedTo instanceof EnumValueDefinitionNode) { |
||
131 | return DirectiveLocationEnum::ENUM_VALUE; |
||
132 | } |
||
133 | if ($appliedTo instanceof InputObjectTypeDefinitionNode || $appliedTo instanceof InputObjectTypeExtensionNode) { |
||
134 | return DirectiveLocationEnum::INPUT_OBJECT; |
||
135 | } |
||
136 | if ($appliedTo instanceof InputValueDefinitionNode) { |
||
137 | $parentNode = $node->getAncestor(2); |
||
138 | return $parentNode instanceof InputObjectTypeDefinitionNode |
||
139 | ? DirectiveLocationEnum::INPUT_FIELD_DEFINITION |
||
140 | : DirectiveLocationEnum::ARGUMENT_DEFINITION; |
||
141 | } |
||
142 | |||
143 | return null; |
||
144 | } |
||
146 |