Issues in PageController.php (master) - Issues in master - diegonobre/symfony-cms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AppBundle/Controller/PageController.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AppBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use AppBundle\Entity\Page;
use AppBundle\Form\Type\PageType;

/**
 * Page controller.
 *
 * @Route("/cms/page")
 */
class PageController extends Controller

{

    /**
     * Lists all Page entities.
     *
     * @Route("/", name="cms_page")
     * @Method("GET")
     * @Template()
     */
    public function indexAction()
    {
        $em = $this->getDoctrine()->getManager();

        $entities = $em->getRepository('AppBundle:Page')->findAll();

        return array(
            'entities' => $entities,
        );
    }
    /**
     * Creates a new Page entity.
     *
     * @Route("/", name="cms_page_create")
     * @Method("POST")
     * @Template("AppBundle:Page:new.html.twig")
     */
    public function createAction(Request $request)
    {
        $entity = new Page();
        $form = $this->createCreateForm($entity);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($entity);
            $em->flush();

            return $this->redirect($this->generateUrl('cms_page_show', array('id' => $entity->getId())));
        }

        return array(
            'entity' => $entity,
            'form'   => $form->createView(),
        );
    }

    /**
     * Creates a form to create a Page entity.
     *
     * @param Page $entity The entity
     *
     * @return \Symfony\Component\Form\Form The form
     */
    private function createCreateForm(Page $entity)
    {
        $form = $this->createForm(new PageType(), $entity, array(
            'action' => $this->generateUrl('cms_page_create'),
            'method' => 'POST',
        ));

        $form->add('submit', 'submit', array('label' => 'Create'));

        return $form;
    }

    /**
     * Displays a form to create a new Page entity.
     *
     * @Route("/new", name="cms_page_new")
     * @Method("GET")
     * @Template()
     */
    public function newAction()
    {
        $entity = new Page();
        $form   = $this->createCreateForm($entity);

        return array(
            'entity' => $entity,
            'form'   => $form->createView(),
        );
    }

    /**
     * Finds and displays a Page entity.
     *
     * @Route("/{id}", name="cms_page_show")
     * @Method("GET")
     * @Template()
     */
    public function showAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AppBundle:Page')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Page entity.');
        }

        $deleteForm = $this->createDeleteForm($id);

        return array(
            'entity'      => $entity,
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Displays a form to edit an existing Page entity.
     *
     * @Route("/{id}/edit", name="cms_page_edit")
     * @Method("GET")
     * @Template()
     */
    public function editAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AppBundle:Page')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Page entity.');
        }

        $editForm = $this->createEditForm($entity);
        $deleteForm = $this->createDeleteForm($id);

        return array(
            'entity'      => $entity,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
    * Creates a form to edit a Page entity.
    *
    * @param Page $entity The entity
    *
    * @return \Symfony\Component\Form\Form The form
    */
    private function createEditForm(Page $entity)
    {
        $form = $this->createForm(new PageType(), $entity, array(
            'action' => $this->generateUrl('cms_page_update', array('id' => $entity->getId())),
            'method' => 'PUT',
        ));

        $form->add('submit', 'submit', array('label' => 'Update'));

        return $form;
    }
    /**
     * Edits an existing Page entity.
     *
     * @Route("/{id}", name="cms_page_update")
     * @Method("PUT")
     * @Template("AppBundle:Page:edit.html.twig")
     */
    public function updateAction(Request $request, $id)
    {
        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository('AppBundle:Page')->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find Page entity.');
        }

        $deleteForm = $this->createDeleteForm($id);
        $editForm = $this->createEditForm($entity);
        $editForm->handleRequest($request);

        if ($editForm->isValid()) {
            $em->flush();

            return $this->redirect($this->generateUrl('cms_page_edit', array('id' => $id)));
        }

        return array(
            'entity'      => $entity,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
    }
    /**
     * Deletes a Page entity.
     *
     * @Route("/{id}", name="cms_page_delete")
     * @Method("DELETE")
     */
    public function deleteAction(Request $request, $id)
    {
        $form = $this->createDeleteForm($id);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $entity = $em->getRepository('AppBundle:Page')->find($id);

            if (!$entity) {
                throw $this->createNotFoundException('Unable to find Page entity.');
            }

            $em->remove($entity);
            $em->flush();
        }

        return $this->redirect($this->generateUrl('cms_page'));
    }

    /**
     * Creates a form to delete a Page entity by id.
     *
     * @param mixed $id The entity id
     *
     * @return \Symfony\Component\Form\Form The form
     */
    private function createDeleteForm($id)
    {
        return $this->createFormBuilder()
            ->setAction($this->generateUrl('cms_page_delete', array('id' => $id)))
            ->setMethod('DELETE')
            ->add('submit', 'submit', array('label' => 'Delete'))
            ->getForm()
        ;
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10			use AppBundle\Entity\Page;
11			use AppBundle\Form\Type\PageType;
12
13			/**
14			* Page controller.
15			*
16			* @Route("/cms/page")
17			*/
18			class PageController extends Controller
			0 ignored issues – show Duplication introduced 2015-12-09 14:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20
21			/**
22			* Lists all Page entities.
23			*
24			* @Route("/", name="cms_page")
25			* @Method("GET")
26			* @Template()
27			*/
28			public function indexAction()
29			{
30			$em = $this->getDoctrine()->getManager();
31
32			$entities = $em->getRepository('AppBundle:Page')->findAll();
33
34			return array(
35			'entities' => $entities,
36			);
37			}
38			/**
39			* Creates a new Page entity.
40			*
41			* @Route("/", name="cms_page_create")
42			* @Method("POST")
43			* @Template("AppBundle:Page:new.html.twig")
44			*/
45			public function createAction(Request $request)
46			{
47			$entity = new Page();
48			$form = $this->createCreateForm($entity);
49			$form->handleRequest($request);
50
51			if ($form->isValid()) {
52			$em = $this->getDoctrine()->getManager();
53			$em->persist($entity);
54			$em->flush();
55
56			return $this->redirect($this->generateUrl('cms_page_show', array('id' => $entity->getId())));
57			}
58
59			return array(
60			'entity' => $entity,
61			'form' => $form->createView(),
62			);
63			}
64
65			/**
66			* Creates a form to create a Page entity.
67			*
68			* @param Page $entity The entity
69			*
70			* @return \Symfony\Component\Form\Form The form
71			*/
72			private function createCreateForm(Page $entity)
73			{
74			$form = $this->createForm(new PageType(), $entity, array(
75			'action' => $this->generateUrl('cms_page_create'),
76			'method' => 'POST',
77			));
78
79			$form->add('submit', 'submit', array('label' => 'Create'));
80
81			return $form;
82			}
83
84			/**
85			* Displays a form to create a new Page entity.
86			*
87			* @Route("/new", name="cms_page_new")
88			* @Method("GET")
89			* @Template()
90			*/
91			public function newAction()
92			{
93			$entity = new Page();
94			$form = $this->createCreateForm($entity);
95
96			return array(
97			'entity' => $entity,
98			'form' => $form->createView(),
99			);
100			}
101
102			/**
103			* Finds and displays a Page entity.
104			*
105			* @Route("/{id}", name="cms_page_show")
106			* @Method("GET")
107			* @Template()
108			*/
109			public function showAction($id)
110			{
111			$em = $this->getDoctrine()->getManager();
112
113			$entity = $em->getRepository('AppBundle:Page')->find($id);
114
115			if (!$entity) {
116			throw $this->createNotFoundException('Unable to find Page entity.');
117			}
118
119			$deleteForm = $this->createDeleteForm($id);
120
121			return array(
122			'entity' => $entity,
123			'delete_form' => $deleteForm->createView(),
124			);
125			}
126
127			/**
128			* Displays a form to edit an existing Page entity.
129			*
130			* @Route("/{id}/edit", name="cms_page_edit")
131			* @Method("GET")
132			* @Template()
133			*/
134			public function editAction($id)
135			{
136			$em = $this->getDoctrine()->getManager();
137
138			$entity = $em->getRepository('AppBundle:Page')->find($id);
139
140			if (!$entity) {
141			throw $this->createNotFoundException('Unable to find Page entity.');
142			}
143
144			$editForm = $this->createEditForm($entity);
145			$deleteForm = $this->createDeleteForm($id);
146
147			return array(
148			'entity' => $entity,
149			'edit_form' => $editForm->createView(),
150			'delete_form' => $deleteForm->createView(),
151			);
152			}
153
154			/**
155			* Creates a form to edit a Page entity.
156			*
157			* @param Page $entity The entity
158			*
159			* @return \Symfony\Component\Form\Form The form
160			*/
161			private function createEditForm(Page $entity)
162			{
163			$form = $this->createForm(new PageType(), $entity, array(
164			'action' => $this->generateUrl('cms_page_update', array('id' => $entity->getId())),
165			'method' => 'PUT',
166			));
167
168			$form->add('submit', 'submit', array('label' => 'Update'));
169
170			return $form;
171			}
172			/**
173			* Edits an existing Page entity.
174			*
175			* @Route("/{id}", name="cms_page_update")
176			* @Method("PUT")
177			* @Template("AppBundle:Page:edit.html.twig")
178			*/
179			public function updateAction(Request $request, $id)
180			{
181			$em = $this->getDoctrine()->getManager();
182
183			$entity = $em->getRepository('AppBundle:Page')->find($id);
184
185			if (!$entity) {
186			throw $this->createNotFoundException('Unable to find Page entity.');
187			}
188
189			$deleteForm = $this->createDeleteForm($id);
190			$editForm = $this->createEditForm($entity);
191			$editForm->handleRequest($request);
192
193			if ($editForm->isValid()) {
194			$em->flush();
195
196			return $this->redirect($this->generateUrl('cms_page_edit', array('id' => $id)));
197			}
198
199			return array(
200			'entity' => $entity,
201			'edit_form' => $editForm->createView(),
202			'delete_form' => $deleteForm->createView(),
203			);
204			}
205			/**
206			* Deletes a Page entity.
207			*
208			* @Route("/{id}", name="cms_page_delete")
209			* @Method("DELETE")
210			*/
211			public function deleteAction(Request $request, $id)
212			{
213			$form = $this->createDeleteForm($id);
214			$form->handleRequest($request);
215
216			if ($form->isValid()) {
217			$em = $this->getDoctrine()->getManager();
218			$entity = $em->getRepository('AppBundle:Page')->find($id);
219
220			if (!$entity) {
221			throw $this->createNotFoundException('Unable to find Page entity.');
222			}
223
224			$em->remove($entity);
225			$em->flush();
226			}
227
228			return $this->redirect($this->generateUrl('cms_page'));
229			}
230
231			/**
232			* Creates a form to delete a Page entity by id.
233			*
234			* @param mixed $id The entity id
235			*
236			* @return \Symfony\Component\Form\Form The form
237			*/
238			private function createDeleteForm($id)
239			{
240			return $this->createFormBuilder()
241			->setAction($this->generateUrl('cms_page_delete', array('id' => $id)))
242			->setMethod('DELETE')
243			->add('submit', 'submit', array('label' => 'Delete'))
244			->getForm()
245			;
246			}
247			}
248

diegonobre / symfony-cms

Issues (8)

Security Analysis not enabled

src/AppBundle/Controller/PageController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like