EvolutionReportController::getSectoralEvolutionSubactivityAction()

Complexity

Conditions	6
Paths	16

Size

Total Lines	53
Code Lines	26

Duplication

Lines	53
Ratio	100 %

Code Coverage

Tests	24
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function getSectoralEvolutionSubactivityAction()

This method seems to be duplicated in your project.

    {
        $sector = (int) $this->params()->fromRoute('sector');

        $response = [];

        $arrSubactividades = $this->entityManager->getRepository(Subactivity::class)
            ->findActivitySectorBySector($sector);

        if (empty($arrSubactividades)) {
            $this->response->setStatusCode(404);

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\ResponseInterface as the method setStatusCode() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Response, Zend\Http\Response, Zend\Http\Response\Stream.

        }

        // TRAIGO LOS VALORES POR ANO
        // LO QUE ESTA ADENTRO DEL LOOP DEBERIA IR ACA

        $arrAnos = [];
        $arrValores = [];

$arrValores is not used, you could remove the assignment.

        $arrColores = [];

$arrColores is not used, you could remove the assignment.

        for ($i = self::START_YEAR; $i <= self::END_YEAR; $i++) {
            $arrAnos[] = $i;
        }

        $column = 2;

        foreach ($arrSubactividades as $subactividad) {
            $response['column_'.$column][] = $subactividad['name'];
            $response['groups'][] = $subactividad['name'];

            foreach ($arrAnos as $ano) {
                // ATENCION, CABECEADA
                // ESTOY EJECUTANDO EL QUERY CADA VEZ QUE NECESITO LA LISTA DE VALORES
                // ESTA PARTE DEBERIA AFUERA DEL LOOP Y SE DEBERIA REUTILIZAR $arrValoresCrudo
                $arrValoresCrudo = $this->entityManager->getRepository(Emission::class)
                    ->findSubactivitySectorBySector($sector);

                if (empty($arrValoresCrudo)) {
                    $this->response->setStatusCode(404);

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\ResponseInterface as the method setStatusCode() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Response, Zend\Http\Response, Zend\Http\Response\Stream.

                }
                // HASTA ACA

                $response['column_'.$column][] = Utils::returnSectorAno($arrValoresCrudo, $subactividad['name'], $ano);
            }

            $column++;
        }

        $arrAnos = array_merge(array('x'), $arrAnos);
        $response['column_1'] = $arrAnos;

        return new JsonModel($response);
    }