ApiTest\Controller\DistributionReportControllerTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	106
Duplicated Lines	56.6 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	11	1
A	testGetSectoralGasesDistributionActionCanBeAccessed()	0	16	1
A	testInvalidRouteDoesNotCrash()	0	5	1
A	testGetWholeSectoralDistributionActionActionCanBeAccessed()	20	20	1
A	testGetSectoralDistributionActionCanBeAccessed()	20	20	1
A	testGetGasesDistributionActionCanBeAccessed()	20	20	1

<?php
/**
 * @link      http://github.com/zendframework/ZendSkeletonApplication for the canonical source repository
 * @copyright Copyright (c) 2005-2016 Zend Technologies USA Inc. (http://www.zend.com)
 * @license   http://framework.zend.com/license/new-bsd New BSD License
 */

namespace ApiTest\Controller;

use Api\Controller\DistributionReportController;
use Zend\Stdlib\ArrayUtils;
use Zend\Test\PHPUnit\Controller\AbstractHttpControllerTestCase;
use Zend\Json\Json;

class DistributionReportControllerTest extends AbstractHttpControllerTestCase
{
    public function setUp()
    {
        $configOverrides = [];

        $this->setApplicationConfig(ArrayUtils::merge(
            include __DIR__.'/../../../../config/application.config.php',
            $configOverrides
        ));

        parent::setUp();
    }

    public function testGetWholeSectoralDistributionActionActionCanBeAccessed()

This method seems to be duplicated in your project.

    {
        $this->dispatch('/informe/distribucion-sectores/2014', 'GET');
        $this->assertResponseStatusCode(200);
        $this->assertResponseHeaderContains('Content-Type', 'application/json; charset=utf-8');
        $this->assertModuleName('api');
        $this->assertControllerName(DistributionReportController::class);
        $this->assertControllerClass('DistributionReportController');
        $this->assertMatchedRouteName('informe-todos-sectores');

        $data = $this->getResponse()->getContent();

        $this->assertJson($data);

        $data = Json::decode($data, Json::TYPE_ARRAY);

        $this->assertArrayHasKey('sector_1', $data);
        $this->assertArrayHasKey('colores', $data);
        $this->assertArrayHasKey('descripciones', $data);
    }

    public function testGetSectoralDistributionActionCanBeAccessed()

This method seems to be duplicated in your project.

    {
        $this->dispatch('/informe/distribucion-sector/2014/1', 'GET');
        $this->assertResponseStatusCode(200);
        $this->assertResponseHeaderContains('Content-Type', 'application/json; charset=utf-8');
        $this->assertModuleName('api');
        $this->assertControllerName(DistributionReportController::class);
        $this->assertControllerClass('DistributionReportController');
        $this->assertMatchedRouteName('informe-por-sector');

        $data = $this->getResponse()->getContent();

        $this->assertJson($data);

        $data = Json::decode($data, Json::TYPE_ARRAY);

        $this->assertArrayHasKey('graph_data', $data);
        $this->assertArrayHasKey('sector', $data);
        $this->assertArrayHasKey('totalActividades', $data);
    }

    public function testGetGasesDistributionActionCanBeAccessed()

This method seems to be duplicated in your project.

    {
        $this->dispatch('/informe/distribucion-gases/2014', 'GET');
        $this->assertResponseStatusCode(200);
        $this->assertResponseHeaderContains('Content-Type', 'application/json; charset=utf-8');
        $this->assertModuleName('api');
        $this->assertControllerName(DistributionReportController::class);
        $this->assertControllerClass('DistributionReportController');
        $this->assertMatchedRouteName('informe-gas');

        $data = $this->getResponse()->getContent();

        $this->assertJson($data);

        $data = Json::decode($data, Json::TYPE_ARRAY);

        $this->assertArrayHasKey('colores', $data);
        $this->assertArrayHasKey('gases', $data);
        $this->assertArrayHasKey('valores', $data);
    }

    public function testGetSectoralGasesDistributionActionCanBeAccessed()
    {
        $this->dispatch('/informe/distribucion-gases-sector/2014', 'GET');
        $this->assertResponseStatusCode(200);
        $this->assertResponseHeaderContains('Content-Type', 'application/json; charset=utf-8');
        $this->assertModuleName('api');
        $this->assertControllerName(DistributionReportController::class);
        $this->assertControllerClass('DistributionReportController');
        $this->assertMatchedRouteName('informe-gas-por-sector');

        $data = $this->getResponse()->getContent();

        $this->assertJson($data);

        $data = Json::decode($data, Json::TYPE_ARRAY);

$data is not used, you could remove the assignment.

    }

    public function testInvalidRouteDoesNotCrash()
    {
        $this->dispatch('/invalid/route', 'GET');
        $this->assertResponseStatusCode(404);
    }

    // public function testInvalidHttpVerbDoesNotCrash()

50% of this comment could be valid code. Did you maybe forget this after debugging?

    // {
    //     $this->dispatch('/informe/distribucion-sectores/2014', 'DELETE');

73% of this comment could be valid code. Did you maybe forget this after debugging?

    //     $this->assertResponseStatusCode(405);

75% of this comment could be valid code. Did you maybe forget this after debugging?

    // }
}