Api\Controller\IndicatorsReportController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	getIndicatorAction()	0	40	3

<?php

namespace Api\Controller;

use Zend\Mvc\Controller\AbstractRestfulController;
use Zend\View\Model\JsonModel;
use Api\Entity\Indicator;
use Api\Entity\IndicatorValue;

/**
 *
 */
class IndicatorsReportController extends AbstractRestfulController
{
    /**
     * Entity manager.
     * @var Doctrine\ORM\EntityManager
     */
    private $entityManager;

    public function __construct($entityManager)
    {
        $this->entityManager = $entityManager;
    }
    public function getIndicatorAction()
    {
        $indicator = (int) $this->params()->fromRoute('indicator');

        $response = [];

        // DATOS GENERALES DEL INDICADOR
        $arrIndicador = $this->entityManager->getRepository(Indicator::class)
            ->getIndicator($indicator);

        foreach ($arrIndicador as $indicador) {
            $response['indicador'] = $indicador;
            break;
        }

        $arrValores = $this->entityManager->getRepository(IndicatorValue::class)
            ->getIndicatorValue($indicator);

        $arrAnos = [];
        $arrValor = [];

        foreach ($arrValores as $a) {
            // SI EL NOMBRE TIENE UNA COMA LO TENGO QUE PONER ENTRE COMILLAS
            $arrAnos[]  = $a['year'];
            $arrValor[] = $a['value'];
        }

        $arrAnos = array_merge(array('x'), $arrAnos);
        $response['column_1'] = $arrAnos;

        $arrValor = array_merge(array($indicador['name']), $arrValor);

The variable $indicador seems to be defined by a foreach iteration on line 35. Are you sure the iterator is never empty, otherwise this variable is not defined?

        $response['column_2'] = $arrValor;

        $response['unidad'] = $indicador['unit'];
        $response['descripcion'] = nl2br($indicador['description']);

        $response['colores'] = "#8064a2";

        return new JsonModel($response);
    }
}