CommonExtension::getConfiguration() - Code Metrics - Inspection of "Add model classes" - diegoangel/call-center-platform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd262a...2b532f )

by Diego

created 2016-10-21 21:53 UTC

CommonExtension::getConfiguration() A

↳ Parent: CommonExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php

namespace CallCenter\Bundle\CommonBundle\DependencyInjection;

use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\Config\FileLocator;

class CommonExtension extends Extension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $loader = new YamlFileLoader(
            $container,
            new FileLocator(__DIR__.'/../Resources/config')
        );
        $loader->load('services.yml');

        $configuration = $this->getConfiguration($configs, $container);
        $config = $this->processConfiguration($configuration, $configs);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        // Fill the array with classes when appropiate
        $this->addClassesToCompile(array());
    }

    /**
     * {@inheritdoc}
     */
    public function getConfiguration(array $config, ContainerBuilder $container)
    {
        return new Configuration($container->getParameter('kernel.debug'));
    }
}


1			<?php
2
3			namespace CallCenter\Bundle\CommonBundle\DependencyInjection;
4
5			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
6			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
7			use Symfony\Component\DependencyInjection\ContainerBuilder;
8			use Symfony\Component\Config\FileLocator;
9
10			class CommonExtension extends Extension
11			{
12			/**
13			* {@inheritdoc}
14			*/
15			public function load(array $configs, ContainerBuilder $container)
16			{
17			$loader = new YamlFileLoader(
18			$container,
19			new FileLocator(__DIR__.'/../Resources/config')
20			);
21			$loader->load('services.yml');
22
23			$configuration = $this->getConfiguration($configs, $container);
24			$config = $this->processConfiguration($configuration, $configs);
			0 ignored issues – show Bug introduced 2016-10-17 00:31 UTC by Report Bug Copy Issue Report It seems like `$configuration` defined by `$this->getConfiguration($configs, $container)` on line `23` can be `null`; however, `Symfony\Component\Depend...:processConfiguration()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
25
26			// Fill the array with classes when appropiate
27			$this->addClassesToCompile(array());
28			}
29
30			/**
31			* {@inheritdoc}
32			*/
33			public function getConfiguration(array $config, ContainerBuilder $container)
34			{
35			return new Configuration($container->getParameter('kernel.debug'));
36			}
37			}
38

diegoangel / call-center-platform

Push — master ( dd262a...2b532f )

CommonExtension::getConfiguration() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like