DiamondByBOLD\FlysystemAzureBlobStorage\AzureBlobStorageAdapter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
A	getUrl()	0	7	3

<?php


namespace DiamondByBOLD\FlysystemAzureBlobStorage;

use League\Flysystem\AzureBlobStorage\AzureBlobStorageAdapter as BaseAzureBlobStorageAdapter;
use MicrosoftAzure\Storage\Blob\BlobRestProxy;

final class AzureBlobStorageAdapter extends BaseAzureBlobStorageAdapter
{
    /**
     * The Azure Blob Client
     *
     * @var BlobRestProxy
     */
    private $client;

Consider using a different property name as you override a private property of the parent class.

    /**
     * The container name
     *
     * @var string
     */
    private $container;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var string
     */
    private $url;

    /**
     * AzureBlobStorageAdapter constructor.
     * @param BlobRestProxy $client
     * @param string $container
     * @param string|null $url
     * @param null $prefix
     * @throws \Exception
     */
    public function __construct(BlobRestProxy $client, string $container, string $url = null, $prefix = null)
    {
        parent::__construct($client, $container, $prefix);

        $this->client = $client;
        $this->container = $container;
        $this->setPathPrefix($prefix);

        if ($url && !filter_var($url, FILTER_VALIDATE_URL)) {

The expression $url of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            throw new \Exception('Invalid Url');
        }
        $this->url = $url;
    }

    public function getUrl(string $path) : string{
        if ($this->url) {
            return rtrim($this->url, '/') . '/' . ($this->container === '$root' ? '' : $this->container . '/') . ltrim($path, '/');
        }

        return $this->client->getBlobUrl($this->container, $path);
    }
}