Justice::findById() - Code Metrics - dfridrich/Ares - Measure and Improve Code Quality continuously with Scrutinizer

Justice::findById() B
last analyzed 2017-11-20 16:52 UTC

↳ Parent: Justice

Complexity

Conditions	5
Paths	2

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	32
ccs	0
cts	26
cp	0
rs	8.439
cc	5
eloc	20
nc	2
nop	1
crap	30

<?php

namespace Defr;

use Assert\Assertion;
use Defr\Justice\JusticeRecord;
use Defr\Justice\SubjectNotFoundException;
use Defr\Parser\JusticeJednatelPersonParser;
use Defr\Parser\JusticeSpolecnikPersonParser;
use Goutte\Client;
use Symfony\Component\DomCrawler\Crawler;

final class Justice
{
    /**
     * @var string
     */
    const URL_BASE = 'https://or.justice.cz/ias/ui/';

    /**
     * @var string
     */
    const URL_SUBJECTS = 'https://or.justice.cz/ias/ui/rejstrik-$firma?ico=%d';

    /**
     * @var Client
     */
    private $client;

    /**
     * Justice constructor.
     *
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * @param int $id
     *
     * @throws SubjectNotFoundException
     *
     * @return JusticeRecord|false
     */
    public function findById($id)
    {
        Assertion::integer($id);

        $crawler = $this->client->request('GET', sprintf(self::URL_SUBJECTS, $id));
        $detailUrl = $this->extractDetailUrlFromCrawler($crawler);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        if (false === $detailUrl) {
            return false;
        }

        $people = [];

        $crawler = $this->client->request('GET', $detailUrl);
        $crawler->filter('.aunp-content .div-table')->each(function (Crawler $table) use (&$people) {
            $title = $table->filter('.vr-hlavicka')->text();

            try {
                if ('jednatel: ' === $title) {
                    $person = JusticeJednatelPersonParser::parseFromDomCrawler($table);
                    $people[$person->getName()] = $person;
                } elseif ('Společník: ' === $title) {
                    $person = JusticeSpolecnikPersonParser::parseFromDomCrawler($table);
                    $people[$person->getName()] = $person;
                }
            } catch (\Exception $e) {
                throw $e;
            }
        });

        return new JusticeRecord($people);
    }

    /**
     * @param Crawler $crawler
     *
     * @return false|string
     */
    private function extractDetailUrlFromCrawler(Crawler $crawler)
    {
        $linksFound = $crawler->filter('.result-links > li > a');
        if (!$linksFound) {
            return false;
        }

        $href = $linksFound->extract(['href']);
        if (!isset($href[1])) {
            return false;
        }

        return self::URL_BASE.$href[1];
    }
}


1			<?php
2
3			namespace Defr;
4
5			use Assert\Assertion;
6			use Defr\Justice\JusticeRecord;
7			use Defr\Justice\SubjectNotFoundException;
8			use Defr\Parser\JusticeJednatelPersonParser;
9			use Defr\Parser\JusticeSpolecnikPersonParser;
10			use Goutte\Client;
11			use Symfony\Component\DomCrawler\Crawler;
12
13			final class Justice
14			{
15			/**
16			* @var string
17			*/
18			const URL_BASE = 'https://or.justice.cz/ias/ui/';
19
20			/**
21			* @var string
22			*/
23			const URL_SUBJECTS = 'https://or.justice.cz/ias/ui/rejstrik-$firma?ico=%d';
24
25			/**
26			* @var Client
27			*/
28			private $client;
29
30			/**
31			* Justice constructor.
32			*
33			* @param Client $client
34			*/
35			public function __construct(Client $client)
36			{
37			$this->client = $client;
38			}
39
40			/**
41			* @param int $id
42			*
43			* @throws SubjectNotFoundException
44			*
45			* @return JusticeRecord\|false
46			*/
47			public function findById($id)
48			{
49			Assertion::integer($id);
50
51			$crawler = $this->client->request('GET', sprintf(self::URL_SUBJECTS, $id));
52			$detailUrl = $this->extractDetailUrlFromCrawler($crawler);
			0 ignored issues – show Bug introduced 2016-02-15 17:36 UTC by Report Bug Copy Issue Report It seems like `$crawler` defined by `$this->client->request('...lf::URL_SUBJECTS, $id))` on line `51` can be `null`; however, `Defr\Justice::extractDetailUrlFromCrawler()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
53
54			if (false === $detailUrl) {
55			return false;
56			}
57
58			$people = [];
59
60			$crawler = $this->client->request('GET', $detailUrl);
61			$crawler->filter('.aunp-content .div-table')->each(function (Crawler $table) use (&$people) {
62			$title = $table->filter('.vr-hlavicka')->text();
63
64			try {
65			if ('jednatel: ' === $title) {
66			$person = JusticeJednatelPersonParser::parseFromDomCrawler($table);
67			$people[$person->getName()] = $person;
68			} elseif ('Společník: ' === $title) {
69			$person = JusticeSpolecnikPersonParser::parseFromDomCrawler($table);
70			$people[$person->getName()] = $person;
71			}
72			} catch (\Exception $e) {
73			throw $e;
74			}
75			});
76
77			return new JusticeRecord($people);
78			}
79
80			/**
81			* @param Crawler $crawler
82			*
83			* @return false\|string
84			*/
85			private function extractDetailUrlFromCrawler(Crawler $crawler)
86			{
87			$linksFound = $crawler->filter('.result-links > li > a');
88			if (!$linksFound) {
89			return false;
90			}
91
92			$href = $linksFound->extract(['href']);
93			if (!isset($href[1])) {
94			return false;
95			}
96
97			return self::URL_BASE.$href[1];
98			}
99			}
100

dfridrich / Ares

Justice::findById() B last analyzed 2017-11-20 16:52 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Justice::findById() B
last analyzed 2017-11-20 16:52 UTC