backend.fcmsensors.SensorService.knownsensors() - Code Metrics - Inspection of "break out camera and sensor services" - dfoderick/fullcycle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 157197...45eeb8 )

by Dave

created 2018-09-13 21:37 UTC

backend.fcmsensors.SensorService.knownsensors() A

↳ Parent: backend.fcmsensors

Complexity

Conditions

Size

Total Lines	5
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nop	1
dl	0
loc	5
rs	10
c	0
b	0
f	0


import backend.fcmutils as utils
import backend.fcmservice
from backend.fcmcache import CacheKeys
from domain.sensors import Sensor, SensorValue

class SensorService(backend.fcmservice.BaseService):
    def __init__(self, config, cache):
        super().__init__(config, cache)
        self.sensor = Sensor('controller', 'DHT22', 'controller')

    def knownsensors(self):
        dknownsensors = self.__cache.gethashset(CacheKeys.knownsensors)
        if dknownsensors is not None and dknownsensors:
            return utils.deserializelist_withschema(SensorValueSchema(), list(dknownsensors.values()))

        return None

    def addknownsensor(self, sensorvalue):
        val = utils.jsonserialize(SensorValueSchema(), sensorvalue)

        self.__cache.putinhashset(CacheKeys.knownsensors, sensorvalue.sensorid, val)



1
2			import backend.fcmutils as utils
3			import backend.fcmservice
4			from backend.fcmcache import CacheKeys
5			from domain.sensors import Sensor, SensorValue
6
7			class SensorService(backend.fcmservice.BaseService):
8			def __init__(self, config, cache):
9			super().__init__(config, cache)
10			self.sensor = Sensor('controller', 'DHT22', 'controller')
11
12			def knownsensors(self):
13			dknownsensors = self.__cache.gethashset(CacheKeys.knownsensors)
14			if dknownsensors is not None and dknownsensors:
15			return utils.deserializelist_withschema(SensorValueSchema(), list(dknownsensors.values()))
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-13 21:38 UTC by Report Bug Copy Issue Report The variable `SensorValueSchema` does not seem to be defined. Loading history...
16			return None
17
18			def addknownsensor(self, sensorvalue):
19			val = utils.jsonserialize(SensorValueSchema(), sensorvalue)
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-13 21:38 UTC by Report Bug Copy Issue Report The variable `SensorValueSchema` does not seem to be defined. Loading history...
20			self.__cache.putinhashset(CacheKeys.knownsensors, sensorvalue.sensorid, val)
21
22

dfoderick / fullcycle

Push — master ( 157197...45eeb8 )

backend.fcmsensors.SensorService.knownsensors() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like