devtoolboxuk\soteria\voku\Resources\Utf8::filter()

Complexity

Conditions	13
Paths	17

Size

Total Lines

55

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

0

<?php
    private function filter($var, $normalization_form = \Normalizer::NFC, $leading_combining = '◌')

The parameter $normalization_form is not named in camelCase.

The parameter $leading_combining is not named in camelCase.

The variable $normalization_form is not named in camelCase.

The variable $leading_combining is not named in camelCase.

This operation has 30 execution paths which exceeds the configured maximum of 10.

    {
        switch (\gettype($var)) {
            case 'array':
                foreach ($var as $key => $value) {
                    $var[$key] = $this->filter($value, $normalization_form, $leading_combining);
                }
                unset($v);

Avoid variables with short names like $v. Configured minimum length is 3.

                break;
            case 'object':
                foreach ($var as $key => $value) {
                    $str[$key] = $this->filter($value, $normalization_form, $leading_combining);

$str was never initialized. Although not strictly required by PHP, it is generally a good practice to add $str = array(); before regardless.

                }
                unset($v);

                break;
            case 'string':

The case body in a switch statement must start on the line following the statement.

                if (strpos($var, "\r") !== false) {
                    // Workaround https://bugs.php.net/65732
                    $var = $this->normalizeLineEnding($var);
                }

                if ($this->isAscii($var) === false) {
                    if (\Normalizer::isNormalized($var, $normalization_form)) {
                        $n = '-';

Avoid variables with short names like $n. Configured minimum length is 3.

                    } else {

The method filter uses an else expression. Else is never necessary and you can simplify the code to work without else.

                        $n = \Normalizer::normalize($var, $normalization_form);

                        if (isset($n[0])) {
                            $var = $n;
                        } else {

The method filter uses an else expression. Else is never necessary and you can simplify the code to work without else.

                            $var = $this->encode('UTF-8', $var, true);

The call to Utf8::encode() has too many arguments starting with true.

                        }
                    }

                    if (
                        $var[0] >= "\x80"
                        &&
                        isset($n[0], $leading_combining[0])
                        &&
                        preg_match('/^\p{Mn}/u', $var)
                    ) {
                        // Prevent leading combining chars
                        // for NFC-safe concatenations.
                        $var = $leading_combining . $var;
                    }
                }

                break;
        }

        return $var;
    }