devtoolboxuk\cerberus\BaseOptions

Complexity

Total Complexity

3

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

83.33%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getOptions()	0	70	2
A	yaml_loaded()	0	4	1

<?php

namespace devtoolboxuk\cerberus;

class BaseOptions
{

    function getOptions()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for getOptions.

    {
        if ($this->yaml_loaded()) {
            return yaml_parse_file(__DIR__ . '/Options.yml');
        } else {

The method getOptions uses an else expression. Else is never necessary and you can simplify the code to work without else.

Blank line found at start of control structure

            return [
                'Detection' => [
                    'Rules' => [
                        'Bots' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => 'sensu'
                        ],
                        'Html' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'Numeric' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'Url' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'DisposableEmail' => [
                            'active' => 1,
                            'score' => 10,
                            'params' => '',
                        ],
                        'InvalidEmail' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'QueryStringKey' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'QueryStringValue' => [
                            'active' => 1,
                            'score' => 1,
                            'params' => '',
                        ],
                        'DifferentCountry' => [
                            'active' => 1,
                            'score' => 10,
                            'params' => '',
                        ],
                        'Country' => [
                            'active' => 1,
                            'score' => 10,
                            'params' => '',
                        ],
                        'Xss' => [
                            'active' => 1,
                            'score' => 10,
                            'params' => '',
                        ]
                    ]
                ]

            ];
        }
    }

    private function yaml_loaded()

The method yaml_loaded is not named in camelCase.

Method name "BaseOptions::yaml_loaded" is not in camel caps format

    {
        return extension_loaded('yaml');
    }
}