AbstractCerberus::isYamlLoaded() - Code Metrics - Inspection of "Updated" - devtoolboxuk/cerberus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f76706...507944 )

by Rob

created 2019-05-25 21:01 UTC

AbstractCerberus::isYamlLoaded() A

↳ Parent: AbstractCerberus

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace devtoolboxuk\cerberus;

use devtoolboxuk\soteria\SoteriaService;

abstract class AbstractCerberus
{

    protected $options = [];
    protected $results = [];
    protected $result = [];
    protected $score = 0;
    protected $soteria;

    public function __construct()
    {
        $this->soteria = new SoteriaService();
        $this->setOptions();
    }

    /**
     * @param $handler
     */
    protected function processWrappers($handler)
    {
        $options = $this->getOption('Detection');

        foreach ($handler->getWrappers() as $wrapper) {


            $wrapper->setOptions($handler->getValue(), $options['Rules']);
            $wrapper->process();
            $this->addResult($wrapper->getScore(), $wrapper->getResult());
        }
    }

    /**
     * @param $name
     * @return mixed|null
     */
    private function getOption($name)
    {
        if (!$this->hasOption($name)) {
            return null;
        }

        return $this->options[$name];
    }

    /**
     * @param $name
     * @return bool
     */
    private function hasOption($name)
    {
        return isset($this->options[$name]);
    }

    /**
     * @param $score
     * @param $result
     * @return $this
     */
    protected function addResult($score, $result)
    {
        if (is_array($result)) {
            $this->addScore($score);
            $this->result = array_merge($this->result, $result);
        }
        return $this;
    }

    /**
     * @param $score
     * @return $this
     */
    private function addScore($score)
    {
        $this->score += $score;
        return $this;
    }


    protected function clearResults()
    {
        $this->results = [];
        $this->result = [];
        $this->score = 0;
    }

    /**
     * @return array
     */
    protected function getOptions()
    {
        return $this->options;
    }

    /**
     * @return bool
     */
    private function isYamlLoaded()
    {
        return extension_loaded('yaml');
    }

    /**
     * @param null $options
     */
    public function setOptions($options = null)

    {

        $baseOptions = new BaseOptions();
        $basic_options = $baseOptions->getOptions();

        if (is_array($options)) {
            $options = $this->arrayMergeRecursiveDistinct($basic_options, $options);
        } else {

            if ($this->isYamlLoaded()) {
                $this->soteria->sanitise()->disinfect($options, 'url');
                if ($this->soteria->sanitise()->result()->isValid()) {
                    $options = $this->arrayMergeRecursiveDistinct($basic_options, yaml_parse_file($options));
                } else {

                    if (file_exists($options)) {
                        $options = $this->arrayMergeRecursiveDistinct($basic_options, yaml_parse_file($options));
                    }
                }
            }
        }

        $this->options = $options;
function aContainsB(array $needle = null, array  $haystack) {
    if (!$needle) {
        return false;
    }

    return array_intersect($haystack, $needle) == $haystack;
}
    }

    /**
     * @param array $merged
     * @param array $array2
     * @return array
     */
    private function arrayMergeRecursiveDistinct($merged = [], $array2 = [])

    {
        if (empty($array2)) {
            return $merged;
        }

        foreach ($array2 as $key => &$value) {
            if (is_array($value) && isset($merged[$key]) && is_array($merged[$key])) {
                $merged[$key] = $this->arrayMergeRecursiveDistinct($merged[$key], $value);
            } else {

                $merged[$key] = $value;
            }
        }
        return $merged;
    }
}

1		<?php
2
3		namespace devtoolboxuk\cerberus;
4
5		use devtoolboxuk\soteria\SoteriaService;
6
7		abstract class AbstractCerberus
8		{
9
10		protected $options = [];
11		protected $results = [];
12		protected $result = [];
13		protected $score = 0;
14		protected $soteria;
15
16		public function __construct()
17		{
18		$this->soteria = new SoteriaService();
19		$this->setOptions();
20		}
21
22		/**
23		* @param $handler
24		*/
25	4	protected function processWrappers($handler)
26		{
27	4	$options = $this->getOption('Detection');
28
29	4	foreach ($handler->getWrappers() as $wrapper) {
		0 ignored issues – show Coding Style introduced 2019-05-25 19:55 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
30
31	4	$wrapper->setOptions($handler->getValue(), $options['Rules']);
32	4	$wrapper->process();
33	4	$this->addResult($wrapper->getScore(), $wrapper->getResult());
34		}
35	4	}
36
37		/**
38		* @param $name
39		* @return mixed\|null
40		*/
41	4	private function getOption($name)
42		{
43	4	if (!$this->hasOption($name)) {
44		return null;
45		}
46
47	4	return $this->options[$name];
48		}
49
50		/**
51		* @param $name
52		* @return bool
53		*/
54	4	private function hasOption($name)
55		{
56	4	return isset($this->options[$name]);
57		}
58
59		/**
60		* @param $score
61		* @param $result
62		* @return $this
63		*/
64	4	protected function addResult($score, $result)
65		{
66	4	if (is_array($result)) {
67	2	$this->addScore($score);
68	2	$this->result = array_merge($this->result, $result);
69		}
70	4	return $this;
71		}
72
73		/**
74		* @param $score
75		* @return $this
76		*/
77	2	private function addScore($score)
78		{
79	2	$this->score += $score;
80	2	return $this;
81		}
82
83
84	4	protected function clearResults()
85		{
86	4	$this->results = [];
87	4	$this->result = [];
88	4	$this->score = 0;
89	4	}
90
91		/**
92		* @return array
93		*/
94		protected function getOptions()
95		{
96		return $this->options;
97		}
98
99		/**
100		* @return bool
101		*/
102		private function isYamlLoaded()
103		{
104		return extension_loaded('yaml');
105		}
106
107		/**
108		* @param null $options
109		*/
110	4	public function setOptions($options = null)
		0 ignored issues – show Coding Style Naming introduced 2019-05-25 20:38 UTC by Report Bug Copy Issue Report The variable $basic_options is not named in camelCase. This check marks variable names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
111		{
112
113	4	$baseOptions = new BaseOptions();
114	4	$basic_options = $baseOptions->getOptions();
115
116	4	if (is_array($options)) {
117	4	$options = $this->arrayMergeRecursiveDistinct($basic_options, $options);
118		} else {
		0 ignored issues – show Coding Style introduced 2019-05-25 20:38 UTC by Report Bug Copy Issue Report The method setOptions uses an else expression. Else is never necessary and you can simplify the code to work without else. Loading history...
119		if ($this->isYamlLoaded()) {
120		$this->soteria->sanitise()->disinfect($options, 'url');
121		if ($this->soteria->sanitise()->result()->isValid()) {
122		$options = $this->arrayMergeRecursiveDistinct($basic_options, yaml_parse_file($options));
123		} else {
		0 ignored issues – show Coding Style introduced 2019-05-25 19:55 UTC by Report Bug Copy Issue Report The method setOptions uses an else expression. Else is never necessary and you can simplify the code to work without else. Loading history...
124		if (file_exists($options)) {
125		$options = $this->arrayMergeRecursiveDistinct($basic_options, yaml_parse_file($options));
126		}
127		}
128		}
129		}
130
131	4	$this->options = $options;
		0 ignored issues – show Documentation Bug introduced 2019-05-25 21:03 UTC by Report Bug Copy Issue Report It seems like `$options` can be `null`. However, the property `$options` is declared as `array`. Maybe change the type of the property to `array\|null` or add a type check? Our type inference engine has found an assignment of a scalar value (like a string, an integer or null) to a property which is an array. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property. To type hint that a parameter can be either an array or null, you can set a type hint of array and a default value of null. The PHP interpreter will then accept both an array or null for that parameter. function aContainsB(array $needle = null, array $haystack) { if (!$needle) { return false; } return array_intersect($haystack, $needle) == $haystack; } The function can be called with either null or an array for the parameter `$needle` but will only accept an array as `$haystack`. Loading history...
132	4	}
133
134		/**
135		* @param array $merged
136		* @param array $array2
137		* @return array
138		*/
139	4	private function arrayMergeRecursiveDistinct($merged = [], $array2 = [])
		0 ignored issues – show Complexity introduced 2019-05-25 19:55 UTC by Report Bug Copy Issue Report This operation has 10 execution paths which exceeds the configured maximum of 10. A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods. You can also find more information in the “Code” section of your repository. Loading history...
140		{
141	4	if (empty($array2)) {
142		return $merged;
143		}
144
145	4	foreach ($array2 as $key => &$value) {
146	4	if (is_array($value) && isset($merged[$key]) && is_array($merged[$key])) {
147	4	$merged[$key] = $this->arrayMergeRecursiveDistinct($merged[$key], $value);
148		} else {
		0 ignored issues – show Coding Style introduced 2019-05-25 19:55 UTC by Report Bug Copy Issue Report The method arrayMergeRecursiveDistinct uses an else expression. Else is never necessary and you can simplify the code to work without else. Loading history...
149	4	$merged[$key] = $value;
150		}
151		}
152	4	return $merged;
153		}
154		}

devtoolboxuk / cerberus

Push — master ( f76706...507944 )

AbstractCerberus::isYamlLoaded() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like