VerificationController::verify() - Code Metrics - Inspection of "tests - wip" - devpri/tinre-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6b9ecc...8f9c24 )

by Paul

created 2020-09-05 10:38 UTC

VerificationController::verify() A

↳ Parent: VerificationController

Complexity

Conditions	6
Paths	6

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	9.5384

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	12
c	1
b	0
f	0
nc	6
nop	1
dl	0
loc	21
ccs	7
cts	13
cp	0.5385
crap	9.5384
rs	9.2222

<?php

namespace Devpri\Tinre\Http\Controllers\Auth;

use Devpri\Tinre\Http\Controllers\Controller;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Request;
use Illuminate\Http\Response;

class VerificationController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Email Verification Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for handling email verification for any
    | user that recently registered with the application. Emails may also
    | be re-sent if the user didn't receive the original email message.
    |
    */

    /**
     * Where to redirect users after verification.
     */
    public function redirectTo()
    {
        return route('dashboard');
    }

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('signed')->only('verify');
        $this->middleware('throttle:6,1')->only('verify', 'resend');
    }

    /**
     * Show the email verification notice.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function show(Request $request)
    {
        return $request->user()->hasVerifiedEmail()

            ? redirect($this->redirectTo())
            : view('tinre::auth.verify');
    }

    /**
     * Mark the authenticated user's email address as verified.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     *
     * @throws \Illuminate\Auth\Access\AuthorizationException
     */
    public function verify(Request $request)
    {
        if (! hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
            throw new AuthorizationException;
        }

        if (! hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
            throw new AuthorizationException;
        }

        if ($request->user()->hasVerifiedEmail()) {
            return $request->wantsJson()

                ? new Response('', 204)
                : redirect($this->redirectTo());
        }

        $request->user()->markEmailAsVerified();

        return $request->wantsJson()

            ? new Response('', 204)
            : redirect($this->redirectTo())->with('status', __('The email was verified!'));
    }

    /**
     * Resend the email verification notification.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function resend(Request $request)
    {
        if ($request->user()->hasVerifiedEmail()) {
            return $request->wantsJson()

                ? new Response('', 204)
                : redirect($this->redirectTo());
        }

        $request->user()->sendEmailVerificationNotification();

        return $request->wantsJson()

            ? new Response('', 202)
            : back()->with('resent', true);
    }
}


1		<?php
2
3		namespace Devpri\Tinre\Http\Controllers\Auth;
4
5		use Devpri\Tinre\Http\Controllers\Controller;
6		use Illuminate\Auth\Access\AuthorizationException;
7		use Illuminate\Http\Request;
8		use Illuminate\Http\Response;
9
10		class VerificationController extends Controller
11		{
12		/*
13		\|--------------------------------------------------------------------------
14		\| Email Verification Controller
15		\|--------------------------------------------------------------------------
16		\|
17		\| This controller is responsible for handling email verification for any
18		\| user that recently registered with the application. Emails may also
19		\| be re-sent if the user didn't receive the original email message.
20		\|
21		*/
22
23		/**
24		* Where to redirect users after verification.
25		*/
26	3	public function redirectTo()
27		{
28	3	return route('dashboard');
29		}
30
31		/**
32		* Create a new controller instance.
33		*
34		* @return void
35		*/
36	5	public function __construct()
37		{
38	5	$this->middleware('auth');
39	5	$this->middleware('signed')->only('verify');
40	5	$this->middleware('throttle:6,1')->only('verify', 'resend');
41	5	}
42
43		/**
44		* Show the email verification notice.
45		*
46		* @param \Illuminate\Http\Request $request
47		* @return \Illuminate\Http\Response
48		*/
49	2	public function show(Request $request)
50		{
51	2	return $request->user()->hasVerifiedEmail()
		0 ignored issues – show Bug Best Practice introduced 2020-08-09 07:53 UTC by Report Bug Copy Issue Report The expression `return $request->user()-...w('tinre::auth.verify')` returns the type `Illuminate\Http\Redirect...se\|Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
52	1	? redirect($this->redirectTo())
53	2	: view('tinre::auth.verify');
54		}
55
56		/**
57		* Mark the authenticated user's email address as verified.
58		*
59		* @param \Illuminate\Http\Request $request
60		* @return \Illuminate\Http\Response
61		*
62		* @throws \Illuminate\Auth\Access\AuthorizationException
63		*/
64	2	public function verify(Request $request)
65		{
66	2	if (! hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
67		throw new AuthorizationException;
68		}
69
70	2	if (! hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
71		throw new AuthorizationException;
72		}
73
74	2	if ($request->user()->hasVerifiedEmail()) {
75		return $request->wantsJson()
		0 ignored issues – show Bug Best Practice introduced 2020-08-09 07:53 UTC by Report Bug Copy Issue Report The expression `return $request->wantsJs...ct($this->redirectTo())` also could return the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
76		? new Response('', 204)
77		: redirect($this->redirectTo());
78		}
79
80	2	$request->user()->markEmailAsVerified();
81
82	2	return $request->wantsJson()
		0 ignored issues – show Bug Best Practice introduced 2020-08-09 07:53 UTC by Report Bug Copy Issue Report The expression `return $request->wantsJs... email was verified!'))` also could return the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
83		? new Response('', 204)
84	2	: redirect($this->redirectTo())->with('status', __('The email was verified!'));
85		}
86
87		/**
88		* Resend the email verification notification.
89		*
90		* @param \Illuminate\Http\Request $request
91		* @return \Illuminate\Http\Response
92		*/
93	1	public function resend(Request $request)
94		{
95	1	if ($request->user()->hasVerifiedEmail()) {
96		return $request->wantsJson()
		0 ignored issues – show Bug Best Practice introduced 2020-08-09 07:53 UTC by Report Bug Copy Issue Report The expression `return $request->wantsJs...ct($this->redirectTo())` also could return the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
97		? new Response('', 204)
98		: redirect($this->redirectTo());
99		}
100
101	1	$request->user()->sendEmailVerificationNotification();
102
103	1	return $request->wantsJson()
		0 ignored issues – show Bug Best Practice introduced 2020-08-09 07:53 UTC by Report Bug Copy Issue Report The expression `return $request->wantsJs...)->with('resent', true)` also could return the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
104		? new Response('', 202)
105	1	: back()->with('resent', true);
106		}
107		}
108

devpri / tinre-core

Push — master ( 6b9ecc...8f9c24 )

VerificationController::verify() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like