DevOp\Core\Http\RequestTrait

Complexity

Total Complexity

14

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Test Coverage

Coverage

20%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	withMethod()	0	10	2
A	withRequestTarget()	0	10	2
A	getUri()	0	3	1
A	getMethod()	0	3	1
A	getRequestTarget()	0	18	4
A	withUri()	0	17	4

<?php
namespace DevOp\Core\Http;

use Psr\Http\Message\UriInterface;

trait RequestTrait
{

    /**
     * @var string
     */
    private $method;

    /**
     * @var string
     */
    private $requestTarget;

    /**
     * @var UriInterface
     */
    private $uri;

    /**
     * @return string
     */
    public function getMethod()
    {
        return $this->method;
    }

    /**
     * @param string $method
     * @return \DevOp\Core\Http\Request|$this
     */
    public function withMethod($method)
    {
        if ($method === $this->method) {
            return $this;
        }

        $clone = clone $this;
        $clone->method = $method;

        return $clone;
    }

    /**
     * @return string
     */
    public function getRequestTarget()
    {
        
        if ($this->requestTarget) {
            return $this->requestTarget;
        }

        $target = $this->uri->getPath();

        if ($target === '') {
            $target .= '/';
        }

        if ($this->uri->getQuery()) {
            $target .= '?' . $this->uri->getQuery();
        }

        return $target;
    }

    /**
     * @param string $requestTarget
     * @return \DevOp\Core\Http\Request|$this
     */
    public function withRequestTarget($requestTarget)
    {
        if ($requestTarget === $this->requestTarget) {
            return $this;
        }

        $clone = clone $this;
        $clone->requestTarget = $requestTarget;

        return $clone;
    }

    /**
     * @return UriInterface
     */
    public function getUri()
    {
        return $this->uri;
    }

    /**
     * @param UriInterface $uri
     * @param boolean $preserveHost
     * @return \DevOp\Core\Http\Request|$this
     */
    public function withUri(UriInterface $uri, $preserveHost = false)
    {
        if ($uri === $this->uri) {
            return $this;
        }

        $clone = clone $this;
        $clone->uri = $uri;

        if ($preserveHost) {
            if (!$clone->hasHeader('host')) {

It seems like hasHeader() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $clone->headers['host'] = 'Host';

The property headers does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $clone->headers['Host'] = [$uri->getHost()];
            }
        }

        return $clone;
    }
}