DevOp\Core\Http\Factory\StreamFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createStreamFromFile()	0	5	1
A	createStreamFromResource()	0	4	1
A	createStream()	0	7	1

<?php
namespace DevOp\Core\Http\Factory;

use DevOp\Core\Http\Stream;
use Psr\Http\Message\StreamInterface;
use Interop\Http\Factory\StreamFactoryInterface;

class StreamFactory implements StreamFactoryInterface
{

    /**
     * @param string $content
     * @return StreamInterface
     */
    public function createStream($content = '')
    {
        $resource = fopen("php://temp", "r+");
        fwrite($resource, $content);

It seems like $resource can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

        rewind($resource);

It seems like $resource can also be of type false; however, parameter $handle of rewind() does only seem to accept resource, maybe add an additional type check?

        return $this->createStreamFromResource($resource);

It seems like $resource can also be of type false; however, parameter $resource of DevOp\Core\Http\Factory\StreamFactory::createStreamFromResource() does only seem to accept resource, maybe add an additional type check?

    }

    /**
     * @param string $filename
     * @param string $mode
     * @return StreamInterface
     */
    public function createStreamFromFile($filename, $mode = 'r')
    {
        $resource = fopen($filename, $mode);

        return $this->createStreamFromResource($resource);

It seems like $resource can also be of type false; however, parameter $resource of DevOp\Core\Http\Factory\StreamFactory::createStreamFromResource() does only seem to accept resource, maybe add an additional type check?

    }

    /**
     * @param resource $resource
     * @return StreamInterface
     */
    public function createStreamFromResource($resource)
    {
        var_dump($resource);

var_dump($resource) looks like debug code. Are you sure you do not want to remove it?

        return new Stream($resource);

$resource of type resource is incompatible with the type Psr\Http\Message\StreamInterface expected by parameter $handle of DevOp\Core\Http\Stream::__construct().

    }
}